Don't use fatal errors in message_kind_test.dart.

dart/tests/compiler/dart2js/message_kind_helper.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.test.message_kind_helper;
 
 import 'package:expect/expect.dart';
 import 'dart:async';
 
 import '../../../sdk/lib/_internal/compiler/implementation/dart2jslib.dart' show
     Compiler,
     MessageKind;
 
 import 'memory_compiler.dart';
 
 const String ESCAPE_REGEXP = r'[[\]{}()*+?.\\^$|]';
 
 /// Most examples generate a single diagnostic.
 /// Add an exception here if a single diagnostic cannot be produced.
 /// However, consider that a single concise diagnostic is easier to understand,
 /// so try to change error reporting logic before adding an exception.
 final Set<MessageKind> kindsWithExtraMessages = new Set<MessageKind>.from([
     // See http://dartbug.com/18361.

[Johnni Winther, 2014/04/25 09:57:55]

Replace . by : to indicated that the bug has to do with the following message
kinds.

[ahe, 2014/04/25 12:51:17]

Done.

+    // If you add something here, please file a *new* bug report.

[Johnni Winther, 2014/04/25 09:57:55]

Move above the previous line.

[ahe, 2014/04/25 12:51:17]

Done.

     MessageKind.CANNOT_EXTEND_MALFORMED,
     MessageKind.CANNOT_IMPLEMENT_MALFORMED,
     MessageKind.CANNOT_MIXIN,
     MessageKind.CANNOT_MIXIN_MALFORMED,
     MessageKind.CYCLIC_TYPEDEF_ONE,
     MessageKind.EQUAL_MAP_ENTRY_KEY,
     MessageKind.FINAL_FUNCTION_TYPE_PARAMETER,
     MessageKind.FORMAL_DECLARED_CONST,
     MessageKind.FORMAL_DECLARED_STATIC,
+    MessageKind.FUNCTION_TYPE_FORMAL_WITH_DEFAULT,
     MessageKind.HEX_DIGIT_EXPECTED,
     MessageKind.HIDDEN_IMPLICIT_IMPORT,
     MessageKind.HIDDEN_IMPORT,
     MessageKind.INHERIT_GETTER_AND_METHOD,
     MessageKind.UNIMPLEMENTED_METHOD,
     MessageKind.UNIMPLEMENTED_METHOD_ONE,
+    MessageKind.UNMATCHED_TOKEN,
     MessageKind.UNTERMINATED_STRING,
     MessageKind.VAR_FUNCTION_TYPE_PARAMETER,
     MessageKind.VOID_NOT_ALLOWED,
-    MessageKind.UNMATCHED_TOKEN,
 ]);
 
 /// Most messages can be tested without causing a fatal error. Add an exception
 /// here if a fatal error is unavoidable and leads to pending classes.
 /// Try to avoid adding exceptions here; a fatal error causes the compiler to
 /// stop before analyzing all input, and it isn't safe to reuse it.
 final Set<MessageKind> kindsWithPendingClasses = new Set<MessageKind>.from([
-    MessageKind.TYPEDEF_FORMAL_WITH_DEFAULT,
+    // If you add something here, please file a new bug report.

[Johnni Winther, 2014/04/25 09:57:55]

new -> *new*

[ahe, 2014/04/25 12:51:17]

Done.

 ]);
 
 /// Most messages can be tested without causing a fatal error. Add an exception
 /// here if a fatal error is unavoidable.
 /// Try to avoid adding exceptions here; a fatal error causes the compiler to
 /// stop before analyzing all input, and it isn't safe to reuse it.
 final Set<MessageKind> kindsWithFatalErrors = new Set<MessageKind>.from([
-    MessageKind.FUNCTION_TYPE_FORMAL_WITH_DEFAULT,
+    // If you add something here, please file a *new* bug report.
     MessageKind.HEX_DIGIT_EXPECTED,
-    MessageKind.REDIRECTING_FACTORY_WITH_DEFAULT,
-    MessageKind.REFERENCE_IN_INITIALIZATION,
-    MessageKind.TYPEDEF_FORMAL_WITH_DEFAULT,
     MessageKind.UNMATCHED_TOKEN,
     MessageKind.UNTERMINATED_STRING,
 ]);
 
 Future<Compiler> check(MessageKind kind, Compiler cachedCompiler) {
   Expect.isNotNull(kind.howToFix);
   Expect.isFalse(kind.examples.isEmpty);
 
   return Future.forEach(kind.examples, (example) {
     if (example is String) {
@@ skipping 44 matching lines @@
       if (!unexpectedMessages.isEmpty) {
         for (String message in unexpectedMessages) {
           print("Unexpected message: $message");
         }
         if (!kindsWithExtraMessages.contains(kind)) {
           // Try changing the error reporting logic before adding an exception
           // to [kindsWithExtraMessages].
           throw 'Unexpected messages found.';
         }
       }
-      cachedCompiler = compiler;
-      Expect.isTrue(kindsWithFatalErrors.contains(kind) ||
-                    !compiler.compilerWasCancelled);
+      Expect.isTrue(!compiler.compilerWasCancelled ||
+                    kindsWithFatalErrors.contains(kind));
 
       bool pendingStuff = false;
       for (var e in compiler.resolver.pendingClassesToBePostProcessed) {
         pendingStuff = true;
         compiler.reportInfo(
             e, MessageKind.GENERIC,
             {'text': 'Pending class to be post-processed.'});
       }
       for (var e in compiler.resolver.pendingClassesToBeResolved) {
         pendingStuff = true;
         compiler.reportInfo(
             e, MessageKind.GENERIC,
             {'text': 'Pending class to be resolved.'});
       }
-      if (pendingStuff) {
-        if (!kindsWithPendingClasses.contains(kind)) {
-          throw 'Stuff was pending';
-        }
-        cachedCompiler = null;
-      } else if (compiler.compilerWasCancelled) {
-        cachedCompiler = null;
-      } else {
+      Expect.isTrue(!pendingStuff || kindsWithPendingClasses.contains(kind));
+
+      if (!pendingStuff && !compiler.compilerWasCancelled) {
+        // If there is pending stuff, or the compiler was cancelled, we
+        // shouldn't reuse the compiler.
         cachedCompiler = compiler;
       }
     });
   }).then((_) => cachedCompiler);
 }