Support for --no-hints in analyzer_experimental.

Support for --no-hints in analyzer_experimental.

I did one more snapshot to pick up your latest changes.
I have to extract ErrorCode variables because of type model difference in Java vs. Dart.

R=brianwilkerson@google.com, jwren@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=28016

[jwren, 2013-09-25 20:58:07]

On 2013/09/25 20:49:56, scheglov wrote:

LGTM

[scheglov, 2013-09-25 21:28:51]

PTAL

[Brian Wilkerson, 2013-09-26 02:12:50]

https://codereview.chromium.org/24669002/diff/9001/editor/tools/plugins/com.g...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java
(right):

https://codereview.chromium.org/24669002/diff/9001/editor/tools/plugins/com.g...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java:373:
ErrorCode errorCode = shouldReportMissingMember_static
I don't understand. What was the purpose for these code changes?

https://codereview.chromium.org/24669002/diff/9001/editor/tools/plugins/com.g...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/task/GenerateDartHintsTask.java
(right):

https://codereview.chromium.org/24669002/diff/9001/editor/tools/plugins/com.g...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/task/GenerateDartHintsTask.java:48:
private boolean enableHints;
I think this is the wrong approach. Given that the purpose of this task is to
generate hints, we should only invoke the task if hints are enabled. We
shouldn't need to check to see whether hints are enabled within this class.

[scheglov, 2013-09-26 20:22:13]

PTAL

https://codereview.chromium.org/24669002/diff/9001/editor/tools/plugins/com.g...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java
(right):

https://codereview.chromium.org/24669002/diff/9001/editor/tools/plugins/com.g...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java:373:
ErrorCode errorCode = shouldReportMissingMember_static
On 2013/09/26 02:12:50, Brian Wilkerson wrote:
> I don't understand. What was the purpose for these code changes?

This is workaround for slight Java vs. Dart type system mismatch.
In Dart type of "condition ? STWC : HindCode" is Enum, even though they both
implement ErrorCode.
So, java2dart needs to generate a typecast.
We could get it from required parameter type or extract it as a local variable
and use its type as a hint.

Eventually we should fix this limitation in javadart.

Although in this case I'd extracted them in any case, just to make code
"regular" - each argument just simple expression - identifier or a short
invocation.

https://codereview.chromium.org/24669002/diff/9001/editor/tools/plugins/com.g...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/task/GenerateDartHintsTask.java
(right):

https://codereview.chromium.org/24669002/diff/9001/editor/tools/plugins/com.g...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/task/GenerateDartHintsTask.java:48:
private boolean enableHints;
On 2013/09/26 02:12:50, Brian Wilkerson wrote:
> I think this is the wrong approach. Given that the purpose of this task is to
> generate hints, we should only invoke the task if hints are enabled. We
> shouldn't need to check to see whether hints are enabled within this class.

OK, agree.
Fixed.

[Brian Wilkerson, 2013-09-27 12:16:55]

LGTM

[scheglov, 2013-09-27 16:54:52]

Committed patchset #4 manually as r28016 (presubmit successful).