Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/AnalysisContextImpl.java

Issue 24669002: Support for --no-hints in analyzer_experimental. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix hint check; print hints in Dart verison. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/AnalysisContextImpl.java
diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/AnalysisContextImpl.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/AnalysisContextImpl.java
index 395c2fdff531dfd28b7feb3d95cbebbbda0b1498..51d17897028c11653d655acac61d83afefa5772a 100644
--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/AnalysisContextImpl.java
+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/AnalysisContextImpl.java
@@ -269,6 +269,7 @@ public class AnalysisContextImpl implements InternalAnalysisContext {
@Override
public AnalysisError[] computeErrors(Source source) throws AnalysisException {
+ boolean enableHints = getAnalysisOptions().getHint();
SourceEntry sourceEntry = getReadableSourceEntry(source);
if (sourceEntry instanceof DartEntry) {
ArrayList<AnalysisError> errors = new ArrayList<AnalysisError>();
@@ -281,7 +282,9 @@ public class AnalysisContextImpl implements InternalAnalysisContext {
getDartResolutionData(source, source, dartEntry, DartEntry.RESOLUTION_ERRORS));
// TODO(brianwilkerson) Gather other kinds of errors when their generation is moved out of
// resolution into separate phases.
- ListUtilities.addAll(errors, getDartHintData(source, source, dartEntry, DartEntry.HINTS));
+ if (enableHints) {
+ ListUtilities.addAll(errors, getDartHintData(source, source, dartEntry, DartEntry.HINTS));
+ }
} else {
Source[] libraries = getLibrariesContaining(source);
for (Source librarySource : libraries) {
@@ -290,9 +293,11 @@ public class AnalysisContextImpl implements InternalAnalysisContext {
getDartResolutionData(source, librarySource, dartEntry, DartEntry.RESOLUTION_ERRORS));
// TODO(brianwilkerson) Gather other kinds of errors when their generation is moved out of
// resolution into separate phases.
- ListUtilities.addAll(
- errors,
- getDartHintData(source, librarySource, dartEntry, DartEntry.HINTS));
+ if (enableHints) {
+ ListUtilities.addAll(
+ errors,
+ getDartHintData(source, librarySource, dartEntry, DartEntry.HINTS));
+ }
}
}
if (errors.isEmpty()) {

Powered by Google App Engine
This is Rietveld 408576698