Issue 246563006: Handle generic parameters in synthesized constructor for mixin applications.

Issue 246563006: Handle generic parameters in synthesized constructor for mixin applications. (Closed)

Created:
6 years, 8 months ago by Johnni Winther

Modified:
6 years, 8 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Handle generic parameters in synthesized constructor for mixin applications. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=35359

Patch Set 3 : Updated cf. comment #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -4 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1 2	1 chunk	+25 lines, -1 line	0 comments	Download
A	tests/language/generic_constructor_mixin2_test.dart	View		1 chunk	+23 lines, -0 lines	0 comments	Download
A	tests/language/generic_constructor_mixin3_test.dart	View		1 chunk	+23 lines, -0 lines	0 comments	Download
A	tests/language/generic_constructor_mixin_test.dart	View		1 chunk	+22 lines, -0 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1 2	2 chunks	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/246563006/diff/20001/sdk/lib/_internal/compiler/implementation/ssa/builder.dart File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right): https://codereview.chromium.org/246563006/diff/20001/sdk/lib/_internal/compiler/implementation/ssa/builder.dart#newcode1617 sdk/lib/_internal/compiler/implementation/ssa/builder.dart:1617: void potentiallyCheckInlinedParameterTypes(FunctionElement function) { Should we bail out ...

6 years, 8 months ago (2014-04-23 17:43:34 UTC) #2

Johnni Winther

https://codereview.chromium.org/246563006/diff/20001/sdk/lib/_internal/compiler/implementation/ssa/builder.dart File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right): https://codereview.chromium.org/246563006/diff/20001/sdk/lib/_internal/compiler/implementation/ssa/builder.dart#newcode1617 sdk/lib/_internal/compiler/implementation/ssa/builder.dart:1617: void potentiallyCheckInlinedParameterTypes(FunctionElement function) { On 2014/04/23 17:43:34, floitsch wrote: ...

6 years, 8 months ago (2014-04-24 08:32:28 UTC) #3

Johnni Winther

6 years, 8 months ago (2014-04-24 08:36:05 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r35359 (presubmit successful).

Expand Messages | Collapse Messages