Handle generic parameters in synthesized constructor for mixin applications.

sdk/lib/_internal/compiler/implementation/ssa/builder.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of ssa;
 
 /**
  * A special element for the extra parameter taken by intercepted
  * methods. We need to implement [TypedElement.type] because our
  * optimizers may look at its declared type.
@@ skipping 1596 matching lines @@
      * arguments are used. See invocations of [pushInvokeDynamic] in
      * [visitForIn].
      */
     return currentNode.asForIn() != null;
   }
 
   /**
    * In checked mode, generate type tests for the parameters of the inlined
    * function.
    */
   void potentiallyCheckInlinedParameterTypes(FunctionElement function) {

[floitsch, 2014/04/23 17:43:34]

Should we bail out immediately if checked mode is not enabled?

[Johnni Winther, 2014/04/24 08:32:28]

Done.

     FunctionSignature signature = function.functionSignature;
+
+    InterfaceType contextType;
+    if (function.isSynthesized && function.isGenerativeConstructor()) {
+      // Synthesized constructors reuse the parameters from the
+      // [targetConstructor]. In face of generic types, the type variables
+      // occurring in the parameter types must be substituted by the type
+      // arguments of the enclosing class.
+      FunctionElement target = function;
+      while (target.targetConstructor != null) {
+        target = target.targetConstructor;
+      }
+      if (target != function) {
+        ClassElement functionClass = function.getEnclosingClass();
+        ClassElement targetClass = target.getEnclosingClass();
+        contextType = functionClass.thisType.asInstanceOf(targetClass);
+      }
+    }
+
     signature.orderedForEachParameter((ParameterElement parameter) {
       HInstruction argument = localsHandler.readLocal(parameter);
-      potentiallyCheckType(argument, parameter.type);
+      DartType parameterType = parameter.type;
+      if (contextType != null) {
+        parameterType = parameterType.substByContext(contextType);
+      }
+      potentiallyCheckType(argument, parameterType);
     });
   }
 
   /**
    * Documentation wanted -- johnniwinther
    *
    * Invariant: [constructors] must contain only implementation elements.
    */
   void inlineSuperOrRedirect(FunctionElement callee,
                              List<HInstruction> compiledArguments,
@@ skipping 4660 matching lines @@
     DartType unaliased = type.unalias(builder.compiler);
     if (unaliased is TypedefType) throw 'unable to unalias $type';
     unaliased.accept(this, builder);
   }
 
   void visitDynamicType(DynamicType type, SsaBuilder builder) {
     ClassElement cls = builder.compiler.findHelper('DynamicRuntimeType');
     builder.push(new HDynamicType(type, new TypeMask.exact(cls)));
   }
 }