Issue 246293008: Do not ignore side effects of a type test or type cast as expression, such

Issue 246293008: Do not ignore side effects of a type test or type cast as expression, such (Closed)

Created:
6 years, 8 months ago by regis

Modified:
6 years, 8 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Do not ignore side effects of a type test or type cast as expression, such as bound errors in checked mode. Added tests. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=35284

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -43 lines)			Patch
M	runtime/vm/flow_graph_builder.h	View	1	2 chunks	+5 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1	2 chunks	+0 lines, -29 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	tests/language/language_analyzer.status	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/language/language_analyzer2.status	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1	2 chunks	+2 lines, -6 lines	0 comments	Download
A	tests/language/malbounded_type_cast2_test.dart	View	1	1 chunk	+32 lines, -0 lines	0 comments	Download
A	tests/language/malbounded_type_test2_test.dart	View	1	1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

https://codereview.chromium.org/246293008/diff/1/tests/language/language_dart2js.status File tests/language/language_dart2js.status (left): https://codereview.chromium.org/246293008/diff/1/tests/language/language_dart2js.status#oldcode236 tests/language/language_dart2js.status:236: # Dart VM problems These issues were fixed a ...

6 years, 8 months ago (2014-04-22 18:12:24 UTC) #1

srdjan

lgtm https://codereview.chromium.org/246293008/diff/1/tests/language/malbounded_type_cast2_test.dart File tests/language/malbounded_type_cast2_test.dart (right): https://codereview.chromium.org/246293008/diff/1/tests/language/malbounded_type_cast2_test.dart#newcode30 tests/language/malbounded_type_cast2_test.dart:30: b.test(); indent 2 spaces https://codereview.chromium.org/246293008/diff/1/tests/language/malbounded_type_test2_test.dart File tests/language/malbounded_type_test2_test.dart (right): ...

6 years, 8 months ago (2014-04-22 20:12:12 UTC) #2

regis

Thanks! https://codereview.chromium.org/246293008/diff/1/tests/language/malbounded_type_cast2_test.dart File tests/language/malbounded_type_cast2_test.dart (right): https://codereview.chromium.org/246293008/diff/1/tests/language/malbounded_type_cast2_test.dart#newcode30 tests/language/malbounded_type_cast2_test.dart:30: b.test(); On 2014/04/22 20:12:13, srdjan wrote: > indent ...

6 years, 8 months ago (2014-04-22 20:47:58 UTC) #3

regis

6 years, 8 months ago (2014-04-22 20:48:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r35284 (presubmit successful).

Expand Messages | Collapse Messages