Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: runtime/vm/flow_graph_builder.h

Issue 246293008: Do not ignore side effects of a type test or type cast as expression, such (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.h
===================================================================
--- runtime/vm/flow_graph_builder.h (revision 35282)
+++ runtime/vm/flow_graph_builder.h (working copy)
@@ -434,6 +434,11 @@
private:
friend class TempLocalScope; // For ReturnDefinition.
+ // Helper to drop the result value.
+ virtual void ReturnValue(Value* value) {
+ Do(new DropTempsInstr(0, value));
+ }
+
// Specify a definition of the final result. Adds the definition to
// the graph, but normally overridden in subclasses.
virtual void ReturnDefinition(Definition* definition) {
@@ -491,9 +496,6 @@
virtual void ReturnDefinition(Definition* definition) {
ReturnValue(Bind(definition));
}
-
- virtual void BuildTypeTest(ComparisonNode* node);
- virtual void BuildTypeCast(ComparisonNode* node);
};
« no previous file with comments | « no previous file | runtime/vm/flow_graph_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698