pkg/docgen: a bunch of cleanup

pkg/docgen: a bunch of cleanup

R=efortuna@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35233

[kevmoo, 2014-04-21 19:22:19]

https://codereview.chromium.org/245673002/diff/1/pkg/docgen/lib/src/generator...
File pkg/docgen/lib/src/generator.dart (right):

https://codereview.chromium.org/245673002/diff/1/pkg/docgen/lib/src/generator...
pkg/docgen/lib/src/generator.dart:186: for (Indexable item in allIndexables) {
Exposed in Indexable

https://codereview.chromium.org/245673002/diff/1/pkg/docgen/lib/src/library_h...
File pkg/docgen/lib/src/library_helpers.dart (left):

https://codereview.chromium.org/245673002/diff/1/pkg/docgen/lib/src/library_h...
pkg/docgen/lib/src/library_helpers.dart:65: final Map<String, Map<String,
Set<Indexable>>> mirrorToDocgen = new Map<String,
Moved to Indexable.dart

https://codereview.chromium.org/245673002/diff/1/pkg/docgen/lib/src/models/cl...
File pkg/docgen/lib/src/models/class.dart (left):

https://codereview.chromium.org/245673002/diff/1/pkg/docgen/lib/src/models/cl...
pkg/docgen/lib/src/models/class.dart:68: if (mirror.owner is LibraryMirror) {
mirror.owner is always a LibraryMirror

https://codereview.chromium.org/245673002/diff/1/pkg/docgen/lib/src/models/du...
File pkg/docgen/lib/src/models/dummy_mirror.dart (left):

https://codereview.chromium.org/245673002/diff/1/pkg/docgen/lib/src/models/du...
pkg/docgen/lib/src/models/dummy_mirror.dart:27: if (mirror == null) return '';
With the change to Library have it's own "fake" Indexable for its owner, we can
now assume that all DummyMirror instances have a non-null owner

https://codereview.chromium.org/245673002/diff/1/pkg/docgen/lib/src/models/du...
pkg/docgen/lib/src/models/dummy_mirror.dart:29: return
dart2js_util.qualifiedNameOf(mirror).replaceAll('.', '-');
Moved to shared method since this logic also exists in Library

https://codereview.chromium.org/245673002/diff/1/pkg/docgen/lib/src/models/in...
File pkg/docgen/lib/src/models/indexable.dart (left):

https://codereview.chromium.org/245673002/diff/1/pkg/docgen/lib/src/models/in...
pkg/docgen/lib/src/models/indexable.dart:33: String get qualifiedName =>
fileName;
Moved impl of fileName to qualifiedName + docs.

Removed fileName as a concept

https://codereview.chromium.org/245673002/diff/1/pkg/docgen/lib/src/models/in...
pkg/docgen/lib/src/models/indexable.dart:121: Indexable get owner => new
DummyMirror(mirror.owner);
Now abstract

https://codereview.chromium.org/245673002/diff/1/pkg/docgen/lib/src/models/in...
File pkg/docgen/lib/src/models/indexable.dart (right):

https://codereview.chromium.org/245673002/diff/1/pkg/docgen/lib/src/models/in...
pkg/docgen/lib/src/models/indexable.dart:61: if (!added) {
Ensure we don't create duplicates

https://codereview.chromium.org/245673002/diff/1/pkg/docgen/lib/src/models/li...
File pkg/docgen/lib/src/models/library.dart (right):

https://codereview.chromium.org/245673002/diff/1/pkg/docgen/lib/src/models/li...
pkg/docgen/lib/src/models/library.dart:175: /// Dummy implementation of
Indexable to represent the owner of a Library.
Only what is needed to answer requests to 'owner' for Library.

[Emily Fortuna, 2014-04-21 22:55:52]

lgtm

[kevmoo, 2014-04-21 23:20:01]

Committed patchset #2 manually as r35233 (presubmit successful).