pkg/docgen: a bunch of cleanup

pkg/docgen/lib/src/models/library.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library docgen.models.library;
 
 import 'dart:io';
 
 import 'package:markdown/markdown.dart' as markdown;
 
@@ skipping 20 matching lines @@
   /// Top-level variables in the library.
   Map<String, Variable> variables;
 
   /// Top-level functions in the library.
   Map<String, Method> functions;
 
   String packageName = '';
   bool _hasBeenCheckedForPackage = false;
   String packageIntro;
 
+  Indexable get owner => const _LibraryOwner();
+
   Library get owningLibrary => this;
 
   /// Returns the [Library] for the given [mirror] if it has already been
   /// created, else creates it.
   factory Library(LibraryMirror mirror) {
     var library = getDocgenObject(mirror);
     if (library is DummyMirror) {
       library = new Library._(mirror);
     }
     return library;
@@ skipping 87 matching lines @@
     var map = {'packageName': packageName};
     map.addAll(super.previewMap);
     if (packageIntro != null) {
       map['packageIntro'] = packageIntro;
     }
     return map;
   }
 
   String get name => docName;
 
-  String get docName {
-    return dart2js_util.qualifiedNameOf(mirror).replaceAll('.', '-');
-  }
+  String get docName => getLibraryDocName(mirror);
 
   /// Generates a map describing the [Library] object.
   Map toMap() => {
     'name': name,
     'qualifiedName': qualifiedName,
     'comment': comment,
     'variables': recurseMap(variables),
     'functions': expandMethodMap(functions),
     'classes': {
       'class': classes.values.where((c) => c.isVisible)
         .map((e) => e.previewMap).toList(),
       'typedef': recurseMap(typedefs),
       'error': errors.values.where((e) => e.isVisible)
           .map((e) => e.previewMap).toList()
     },
     'packageName': packageName,
     'packageIntro': packageIntro
   };
 
   String get typeName => 'library';
 
   bool isValidMirror(DeclarationMirror mirror) => mirror is LibraryMirror;
 }
+
+/// Dummy implementation of Indexable to represent the owner of a Library.

[kevmoo, 2014/04/21 19:22:19]

Only what is needed to answer requests to 'owner' for Library.

+class _LibraryOwner implements Indexable {
+  const _LibraryOwner();
+
+  String get docName => '';
+
+  bool get isPrivate => false;
+
+  Indexable get owner => null;
+
+  // This is a known incomplete implementation of Indexable
+  // overriding noSuchMethod to remove static warnings
+  noSuchMethod(Invocation invocation) {
+    throw new UnimplementedError(invocation.memberName.toString());
+  }
+}