Issue 24493006: Implement named arguments in InstanceMirror.invoke.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24493006: Implement named arguments in InstanceMirror.invoke. (Closed)

Created:
7 years, 2 months ago by ahe

Modified:
7 years, 2 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org, kasperl, Johnni Winther, zarah, rmacnak

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Implement named arguments in InstanceMirror.invoke. BUG=http://dartbug.com/12863 R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=27936

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+158 lines, -36 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/js/builder.dart	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View	1	8 chunks	+46 lines, -4 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	dart/sdk/lib/_internal/lib/js_helper.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	dart/sdk/lib/_internal/lib/js_mirrors.dart	View	1	4 chunks	+64 lines, -9 lines	0 comments	Download
M	dart/tests/lib/lib.status	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/lib/mirrors/invoke_named_test.dart	View	1	12 chunks	+30 lines, -17 lines	0 comments	Download
M	dart/tests/lib/mirrors/invoke_test.dart	View	1	5 chunks	+6 lines, -4 lines	0 comments	Download

Total messages: 5 (0 generated)

ahe

This should implement named arguments, but doesn't yet invoke noSuchMethod when something is wrong.

7 years, 2 months ago (2013-09-25 14:24:41 UTC) #1

ahe

Thank you, Nicolas! I'm going to submit this as soon as I'm confident that the ...

7 years, 2 months ago (2013-09-26 08:16:58 UTC) #3

ahe

7 years, 2 months ago (2013-09-26 09:08:26 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r27936 (presubmit successful).