dart/sdk/lib/_internal/lib/js_helper.dart - Issue 24493006: Implement named arguments in InstanceMirror.invoke.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/lib/js_helper.dart

Issue 24493006: Implement named arguments in InstanceMirror.invoke. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Tweaked test to get a little test coverage Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dart/sdk/lib/_internal/lib/js_helper.dart

diff --git a/dart/sdk/lib/_internal/lib/js_helper.dart b/dart/sdk/lib/_internal/lib/js_helper.dart

index 073436ecea169ef59f502ec39fba3eece762e471..3737c4acd1bd7810dd06dc4a71667999bd6e567e 100644

--- a/dart/sdk/lib/_internal/lib/js_helper.dart

+++ b/dart/sdk/lib/_internal/lib/js_helper.dart

@@ -667,7 +667,6 @@ class Primitives {

arguments.addAll(positionalArguments);

}

- // TODO(ahe): Use JS_SOMETHING to get name from Namer.

if (JS('bool', r'# in #', JS_GET_NAME('CALL_CATCH_ALL'), function)) {

// We expect the closure to have a "call$catchAll" (the value of

// JS_GET_NAME('CALL_CATCH_ALL')) function that returns all the expected