Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 244253009: Fix for issue 18273 (Closed)

Created:
6 years, 8 months ago by Brian Wilkerson
Modified:
6 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Clean-up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+265 lines, -12 lines) Patch
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/element/LibraryElement.java View 2 chunks +15 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/context/AnalysisContextImpl.java View 1 chunk +8 lines, -1 line 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/LibraryElementImpl.java View 6 chunks +78 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/element/handle/LibraryElementHandle.java View 1 chunk +10 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java View 3 chunks +42 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/LibraryResolver.java View 1 chunk +3 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/sdk/DartSdk.java View 1 chunk +5 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/context/AnalysisContextFactory.java View 4 chunks +60 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/element/ElementFactory.java View 2 chunks +23 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/resolver/TypeProviderImplTest.java View 1 chunk +7 lines, -7 lines 0 comments Download
M editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java View 1 chunk +14 lines, -0 lines 0 comments Download
M tests/language/language_analyzer.status View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Brian Wilkerson
6 years, 8 months ago (2014-04-21 22:17:36 UTC) #1
scheglov
LGTM
6 years, 8 months ago (2014-04-21 23:26:08 UTC) #2
Brian Wilkerson
6 years, 8 months ago (2014-04-22 14:44:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r35260 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698