editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/resolver/TypeProviderImplTest.java - Issue 244253009: Fix for issue 18273

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/resolver/TypeProviderImplTest.java

Issue 244253009: Fix for issue 18273 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Clean-up Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/element/ElementFactory.java ('k') | editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/resolver/TypeProviderImplTest.java

diff --git a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/resolver/TypeProviderImplTest.java b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/resolver/TypeProviderImplTest.java

index 546419fcff01ac3c57cc55cdf7de54d610b9ca71..8d359175300df082a299373518e8851da8fb1a71 100644

--- a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/resolver/TypeProviderImplTest.java

+++ b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/resolver/TypeProviderImplTest.java

@@ -46,20 +46,20 @@ public class TypeProviderImplTest extends EngineTestCase {

InterfaceType stringType = classElement("String", objectType).getType();

InterfaceType symbolType = classElement("Symbol", objectType).getType();

InterfaceType typeType = classElement("Type", objectType).getType();

- CompilationUnitElementImpl unit = new CompilationUnitElementImpl("lib.dart");

- unit.setTypes(new ClassElement[] {

+ CompilationUnitElementImpl coreUnit = new CompilationUnitElementImpl("core.dart");

+ coreUnit.setTypes(new ClassElement[] {

boolType.getElement(), doubleType.getElement(), functionType.getElement(),

intType.getElement(), listType.getElement(), mapType.getElement(), objectType.getElement(),

stackTraceType.getElement(), stringType.getElement(), symbolType.getElement(),

- typeType.getElement(),});

- LibraryElementImpl library = new LibraryElementImpl(

+ typeType.getElement()});

+ LibraryElementImpl coreLibrary = new LibraryElementImpl(

new AnalysisContextImpl(),

- libraryIdentifier("lib"));

- library.setDefiningCompilationUnit(unit);

+ libraryIdentifier("dart.core"));

+ coreLibrary.setDefiningCompilationUnit(coreUnit);

// Create a type provider and ensure that it can return the expected types.

- TypeProviderImpl provider = new TypeProviderImpl(library);

+ TypeProviderImpl provider = new TypeProviderImpl(coreLibrary);

assertSame(boolType, provider.getBoolType());

assertNotNull(provider.getBottomType());

assertSame(doubleType, provider.getDoubleType());