Analysis server context ID is now specified by the client.

Analysis server context ID is now specified by the client.

This allows the client to start sending commands that use the context
immediately, without having to wait for a response to find out the
context ID.

If the client tries to create two contexts with the same ID, that is
an error.

R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35185

[Brian Wilkerson, 2014-04-18 21:58:24]

LGTM

https://codereview.chromium.org/243753002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/domain_server.dart (right):

https://codereview.chromium.org/243753002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/domain_server.dart:98: String contextId =
request.getParameter(CONTEXT_ID_PARAM);
I think this should use getRequiredParameter.

We should also probably create and use a toString method (similar to toInt and
toBool) that will generate an error if the value of the parameter isn't a
String.

[Paul Berry, 2014-04-18 22:20:57]

Committed patchset #1 manually as r35185 (presubmit successful).

[Paul Berry, 2014-04-18 22:21:18]

https://codereview.chromium.org/243753002/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/domain_server.dart (right):

https://codereview.chromium.org/243753002/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/domain_server.dart:98: String contextId =
request.getParameter(CONTEXT_ID_PARAM);
On 2014/04/18 21:58:25, Brian Wilkerson wrote:
> I think this should use getRequiredParameter.

Done.

> 
> We should also probably create and use a toString method (similar to toInt and
> toBool) that will generate an error if the value of the parameter isn't a
> String.

Ok, I'll do that as a follow-up CL.