Analysis server context ID is now specified by the client.

pkg/analysis_server/lib/src/domain_server.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library domain.server;
 
 import 'package:analysis_server/src/analysis_server.dart';
 import 'package:analysis_server/src/protocol.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/java_io.dart';
@@ skipping 35 matching lines @@
    * The name of the packageMap parameter.
    */
   static const String PACKAGE_MAP_PARAM = 'packageMap';
 
   /**
    * The name of the sdkDirectory parameter.
    */
   static const String SDK_DIRECTORY_PARAM = 'sdkDirectory';
 
   /**
-   * The name of the contextId result value.
-   */
-  static const String CONTEXT_ID_RESULT = 'contextId';
-
-  /**
    * The name of the version result value.
    */
   static const String VERSION_RESULT = 'version';
 
   /**
    * The analysis server that is using this handler to process requests.
    */
   final AnalysisServer server;
 
   /**
@@ skipping 22 matching lines @@
 
   /**
    * Create a new context in which analysis can be performed. The context that
    * is created will persist until server.deleteContext is used to delete it.
    * Clients, therefore, are responsible for managing the lifetime of contexts.
    */
   Response createContext(Request request) {
     String sdkDirectory = request.getRequiredParameter(SDK_DIRECTORY_PARAM);
     Map<String, String> packageMap = request.getParameter(PACKAGE_MAP_PARAM);
 
-    String baseContextId = new DateTime.now().millisecondsSinceEpoch.toRadixString(16);
-    String contextId = baseContextId;
-    int index = 1;
-    while (server.contextMap.containsKey(contextId)) {
-      contextId = '$baseContextId-$index';
+    String contextId = request.getParameter(CONTEXT_ID_PARAM);

[Brian Wilkerson, 2014/04/18 21:58:25]

I think this should use getRequiredParameter.

We should also probably create and use a toString method (similar to toInt and
toBool) that will generate an error if the value of the parameter isn't a
String.

[Paul Berry, 2014/04/18 22:21:19]

Done.
Ok, I'll do that as a follow-up CL.

+    if (server.contextMap.containsKey(contextId)) {
+      return new Response.contextAlreadyExists(request);
     }
     AnalysisContext context = AnalysisEngine.instance.createAnalysisContext();
     // TODO(brianwilkerson) Use the information from the request to set the
     // source factory in the context.
     DirectoryBasedDartSdk sdk;
     try {
       sdk = new DirectoryBasedDartSdk(new JavaFile(sdkDirectory));
     } on Exception catch (e) {
       // TODO what error code should be returned here?
       return new Response(request.id, new RequestError(
           RequestError.CODE_SDK_ERROR, 'Failed to access sdk: $e'));
     }
     context.sourceFactory = new SourceFactory([
       new DartUriResolver(sdk),
       new FileUriResolver(),
       // new PackageUriResolver(),
     ]);
     server.contextMap[contextId] = context;
 
     Response response = new Response(request.id);
-    response.setResult(CONTEXT_ID_RESULT, contextId);
     return response;
   }
 
   /**
    * Delete the context with the given id. Future attempts to use the context id
    * will result in an error being returned.
    */
   Response deleteContext(Request request) {
     String contextId = request.getRequiredParameter(CONTEXT_ID_PARAM);
 
@@ skipping 16 matching lines @@
 
   /**
    * Return the version number of the analysis server.
    */
   Response version(Request request) {
     Response response = new Response(request.id);
     response.setResult(VERSION_RESULT, '0.0.1');
     return response;
   }
 }