Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 24372002: Int32, Int64 default constructor now takes an optional int parameter. (Closed)

Created:
7 years, 3 months ago by Chris Bracken
Modified:
7 years, 3 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Int32, Int64 default constructor now takes an optional int parameter. Deprecated.fromInt(). BUG= R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=27777

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+373 lines, -404 lines) Patch
M pkg/fixnum/lib/fixnum.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/fixnum/lib/src/int32.dart View 9 chunks +23 lines, -16 lines 0 comments Download
M pkg/fixnum/lib/src/int64.dart View 7 chunks +13 lines, -12 lines 0 comments Download
M pkg/fixnum/pubspec.yaml View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/fixnum/test/int_32_test.dart View 1 chunk +140 lines, -146 lines 0 comments Download
M pkg/fixnum/test/int_64_test.dart View 16 chunks +193 lines, -230 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Chris Bracken
7 years, 3 months ago (2013-09-23 16:40:26 UTC) #1
sra1
lgtm
7 years, 3 months ago (2013-09-23 16:50:21 UTC) #2
Chris Bracken
7 years, 3 months ago (2013-09-23 16:53:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27777 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698