Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: pkg/fixnum/lib/src/int32.dart

Issue 24372002: Int32, Int64 default constructor now takes an optional int parameter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/fixnum/lib/fixnum.dart ('k') | pkg/fixnum/lib/src/int64.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/fixnum/lib/src/int32.dart
diff --git a/pkg/fixnum/lib/src/int32.dart b/pkg/fixnum/lib/src/int32.dart
index 85fbdc460d892ce4fa07f19e2c16153875cc8c1c..a160058176e856c909bdb2783fb4bdba2b293cc0 100644
--- a/pkg/fixnum/lib/src/int32.dart
+++ b/pkg/fixnum/lib/src/int32.dart
@@ -81,7 +81,7 @@ class Int32 implements IntX {
/**
* Parses a decimal [String] and returns an [Int32].
*/
- static Int32 parseInt(String s) => new Int32.fromInt(int.parse(s));
+ static Int32 parseInt(String s) => new Int32(int.parse(s));
/**
* Parses a hexadecimal [String] and returns an [Int32].
@@ -136,7 +136,14 @@ class Int32 implements IntX {
* Constructs an [Int32] from an [int]. Only the low 32 bits of the input
* are used.
*/
- Int32.fromInt(int i) : _i = (i & 0x7fffffff) - (i & 0x80000000);
+ Int32([int i=0]) : _i = (i & 0x7fffffff) - (i & 0x80000000);
+
+ /**
+ * Constructs an [Int32] from an [int]. Only the low 32 bits of the input
+ * are used.
+ */
+ @deprecated
+ Int32.fromInt(int i) : this(i);
// Returns the [int] representation of the specified value. Throws
// [ArgumentError] for non-integer arguments.
@@ -167,17 +174,17 @@ class Int32 implements IntX {
if (other is Int64) {
return this.toInt64() + other;
}
- return new Int32.fromInt(_i + _toInt(other));
+ return new Int32(_i + _toInt(other));
}
IntX operator -(other) {
if (other is Int64) {
return this.toInt64() - other;
}
- return new Int32.fromInt(_i - _toInt(other));
+ return new Int32(_i - _toInt(other));
}
- Int32 operator -() => new Int32.fromInt(-_i);
+ Int32 operator -() => new Int32(-_i);
IntX operator *(other) {
if (other is Int64) {
@@ -192,14 +199,14 @@ class Int32 implements IntX {
// Result will be Int32
return (this.toInt64() % other).toInt32();
}
- return new Int32.fromInt(_i % _toInt(other));
+ return new Int32(_i % _toInt(other));
}
Int32 operator ~/(other) {
if (other is Int64) {
return (this.toInt64() ~/ other).toInt32();
}
- return new Int32.fromInt(_i ~/ _toInt(other));
+ return new Int32(_i ~/ _toInt(other));
}
Int32 remainder(other) {
@@ -214,31 +221,31 @@ class Int32 implements IntX {
if (other is Int64) {
return (this.toInt64() & other).toInt32();
}
- return new Int32.fromInt(_i & _toInt(other));
+ return new Int32(_i & _toInt(other));
}
Int32 operator |(other) {
if (other is Int64) {
return (this.toInt64() | other).toInt32();
}
- return new Int32.fromInt(_i | _toInt(other));
+ return new Int32(_i | _toInt(other));
}
Int32 operator ^(other) {
if (other is Int64) {
return (this.toInt64() ^ other).toInt32();
}
- return new Int32.fromInt(_i ^ _toInt(other));
+ return new Int32(_i ^ _toInt(other));
}
- Int32 operator ~() => new Int32.fromInt(~_i);
+ Int32 operator ~() => new Int32(~_i);
Int32 operator <<(int n) {
if (n < 0) {
throw new ArgumentError(n);
}
n &= 31;
- return new Int32.fromInt(_i << n);
+ return new Int32(_i << n);
}
Int32 operator >>(int n) {
@@ -252,7 +259,7 @@ class Int32 implements IntX {
} else {
value = (_i >> n) | (0xffffffff << (32 - n));
}
- return new Int32.fromInt(value);
+ return new Int32(value);
}
Int32 shiftRightUnsigned(int n) {
@@ -266,7 +273,7 @@ class Int32 implements IntX {
} else {
value = (_i >> n) & ((1 << (32 - n)) - 1);
}
- return new Int32.fromInt(value);
+ return new Int32(value);
}
/**
@@ -328,7 +335,7 @@ class Int32 implements IntX {
int get hashCode => _i;
- Int32 abs() => _i < 0 ? new Int32.fromInt(-_i) : this;
+ Int32 abs() => _i < 0 ? new Int32(-_i) : this;
int numberOfLeadingZeros() => _numberOfLeadingZeros(_i);
int numberOfTrailingZeros() => _numberOfTrailingZeros(_i);
@@ -344,7 +351,7 @@ class Int32 implements IntX {
int toInt() => _i;
Int32 toInt32() => this;
- Int64 toInt64() => new Int64.fromInt(_i);
+ Int64 toInt64() => new Int64(_i);
String toString() => _i.toString();
String toHexString() => _i.toRadixString(16);
« no previous file with comments | « pkg/fixnum/lib/fixnum.dart ('k') | pkg/fixnum/lib/src/int64.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698