Issue 24361003: Fix http://dartbug.com/13462

Issue 24361003: Fix http://dartbug.com/13462 (Closed)

Created:
7 years, 3 months ago by kasperl

Modified:
7 years, 3 months ago

Reviewers:
Johnni Winther, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix http://dartbug.com/13462. R=johnniwinther@google.com, ngeoffray@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=27759

Patch Set 2 : Add copyright. #

Patch Set 3 : Add TODO. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -8 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/compile_time_constants.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart	View	1 2	1 chunk	+4 lines, -1 line	0 comments	Download
A +	tests/language/regress_13462_0_test.dart	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
A +	tests/language/regress_13462_1_test.dart	View	1	1 chunk	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/24361003/diff/1/sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart File sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart (right): https://codereview.chromium.org/24361003/diff/1/sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart#newcode694 sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart:694: return types.nonNullSubtype(compiler.symbolClass.rawType); Add a TODO. We should be ...

7 years, 3 months ago (2013-09-23 12:50:57 UTC) #3

kasperl

Committed patchset #3 manually as r27759 (presubmit successful).

7 years, 3 months ago (2013-09-23 13:12:28 UTC) #4

kasperl

https://codereview.chromium.org/24361003/diff/1/sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart File sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart (right): https://codereview.chromium.org/24361003/diff/1/sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart#newcode694 sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart:694: return types.nonNullSubtype(compiler.symbolClass.rawType); On 2013/09/23 12:50:57, Johnni Winther wrote: > ...

7 years, 3 months ago (2013-09-23 13:13:49 UTC) #5

Message was sent while issue was closed.

LGTM

Expand Messages | Collapse Messages