sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart - Issue 24361003: Fix http://dartbug.com/13462

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart

Issue 24361003: Fix http://dartbug.com/13462 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Add TODO. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/compile_time_constants.dart ('k') | tests/language/regress_13462_0_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart

diff --git a/sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart b/sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart

index 7f9cef0deb29e8732b84e65b8da234f55b5a1005..680e706e1ba8499c273a89e88ac13bc1168d7081 100644

--- a/sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart

+++ b/sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart

@@ -691,7 +691,10 @@ abstract class InferrerVisitor

}

T visitLiteralSymbol(LiteralSymbol node) {

- return types.nonNullExact(compiler.symbolClass.rawType);

+ // TODO(kasperl): We should be able to tell that the type of a literal

+ // symbol is always a non-null exact symbol implementation -- not just

+ // any non-null subtype of the symbol interface.

+ return types.nonNullSubtype(compiler.symbolClass.rawType);

}

T visitTypeReferenceSend(Send node) {

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/compile_time_constants.dart ('k') | tests/language/regress_13462_0_test.dart » ('j') | no next file with comments »