Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 24360002: VM: Fix bug in constant propagation with integer division and modulo. (Closed)

Created:
7 years, 3 months ago by Florian Schneider
Modified:
7 years, 3 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

VM: Fix bug in constant propagation with integer division and modulo. BUG=https://code.google.com/p/dart/issues/detail?id=13498 TEST=tests/language/div_with_power_of_two2_test.dart R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=27757

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M runtime/vm/flow_graph_optimizer.cc View 1 chunk +9 lines, -3 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Florian Schneider
7 years, 3 months ago (2013-09-23 11:30:27 UTC) #1
Kevin Millikin (Google)
lgtm
7 years, 3 months ago (2013-09-23 11:40:05 UTC) #2
Florian Schneider
7 years, 3 months ago (2013-09-23 11:52:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27757 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698