Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 24360002: VM: Fix bug in constant propagation with integer division and modulo. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/language/language.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_optimizer.cc
===================================================================
--- runtime/vm/flow_graph_optimizer.cc (revision 27750)
+++ runtime/vm/flow_graph_optimizer.cc (working copy)
@@ -6419,11 +6419,17 @@
const Integer& left_int = Integer::Cast(left);
const Integer& right_int = Integer::Cast(right);
switch (op_kind) {
+ case Token::kTRUNCDIV:
+ case Token::kMOD:
+ // Check right value for zero.
+ if (right_int.AsInt64Value() == 0) {
+ SetValue(instr, non_constant_);
+ break;
+ }
+ // Fall through.
case Token::kADD:
case Token::kSUB:
- case Token::kMUL:
- case Token::kTRUNCDIV:
- case Token::kMOD: {
+ case Token::kMUL: {
Instance& result = Integer::ZoneHandle(
left_int.ArithmeticOp(op_kind, right_int));
result = result.CheckAndCanonicalize(NULL);
« no previous file with comments | « no previous file | tests/language/language.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698