Issue 243133004: Check for class id overflow to exit rather than crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 243133004: Check for class id overflow to exit rather than crash. (Closed)

Created:
6 years, 8 months ago by koda

Modified:
6 years, 8 months ago

Reviewers:
rmacnak, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Check for class id overflow to exit rather than crash. BUG=dart:18284 R=iposva@google.com, rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=35170

Patch Set 2 : #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	runtime/vm/class_table.cc	View		2 chunks	+5 lines, -1 line	1 comment	Download
	M	runtime/vm/object.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

koda

Example output: $ out/DebugIA32/dart bug.dart runtime/vm/class_table.cc:94: error: Fatal error in ClassTable::Register: invalid index 65536

6 years, 8 months ago (2014-04-18 16:36:55 UTC) #2

Ivan Posva

LGTM -ip https://codereview.chromium.org/243133004/diff/20001/runtime/vm/class_table.cc File runtime/vm/class_table.cc (right): https://codereview.chromium.org/243133004/diff/20001/runtime/vm/class_table.cc#newcode93 runtime/vm/class_table.cc:93: FATAL1("Fatal error in ClassTable::Register: invalid index %" ...

6 years, 8 months ago (2014-04-18 16:39:27 UTC) #4

koda

6 years, 8 months ago (2014-04-18 16:42:04 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r35170 (presubmit successful).

Expand Messages | Collapse Messages

Issue 243133004: Check for class id overflow to exit rather than crash. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages