runtime/vm/object.h - Issue 243133004: Check for class id overflow to exit rather than crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.h

Issue 243133004: Check for class id overflow to exit rather than crash. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/object.h

===================================================================

--- runtime/vm/object.h (revision 35144)

+++ runtime/vm/object.h (working copy)

@@ -691,8 +691,12 @@

raw_ptr()->handle_vtable_ = value;

}

+ static bool is_valid_id(intptr_t value) {

+ return RawObject::ClassIdTag::is_valid(value);

+ }

intptr_t id() const { return raw_ptr()->id_; }

void set_id(intptr_t value) const {

+ ASSERT(is_valid_id(value));

raw_ptr()->id_ = value;

}

« runtime/vm/class_table.cc ('K') | « runtime/vm/class_table.cc ('k') | no next file » | no next file with comments »