Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 24268002: Fix bug in the closure methods, where iterating over the boxed variable did not return the variable… (Closed)

Created:
7 years, 3 months ago by ngeoffray
Modified:
7 years, 3 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix bug in the closure methods, where iterating over the boxed variable did not return the variables boxed due to loops. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=27652

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -14 lines) Patch
M sdk/lib/_internal/compiler/implementation/closure.dart View 4 chunks +17 lines, -8 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart View 1 chunk +3 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_closure_test.dart View 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 3 months ago (2013-09-19 09:34:16 UTC) #1
kasperl
LGTM.
7 years, 3 months ago (2013-09-19 09:35:50 UTC) #2
ngeoffray
7 years, 3 months ago (2013-09-19 10:07:54 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27652 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698