sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart - Issue 24268002: Fix bug in the closure methods, where iterating over the boxed variable did not return the variable…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart

Issue 24268002: Fix bug in the closure methods, where iterating over the boxed variable did not return the variable… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/closure.dart ('k') | tests/compiler/dart2js/simple_inferrer_closure_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart (revision 27646)

+++ sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart (working copy)

@@ -1665,12 +1665,9 @@

ClosureClassMap closureData =

compiler.closureToClassMapper.computeClosureToClassMapping(

analyzedElement, node, elements);

- ClosureScope scopeData = closureData.capturingScopes[node];

- if (scopeData != null) {

- scopeData.capturedVariableMapping.forEach((variable, field) {

- locals.setCapturedAndBoxed(variable, field);

- });

- }

+ closureData.forEachBoxedVariable((variable, field) {

+ locals.setCapturedAndBoxed(variable, field);

+ });

if (analyzedElement.isField()) {

return visit(node.asSendSet().arguments.head);

}

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/closure.dart ('k') | tests/compiler/dart2js/simple_inferrer_closure_test.dart » ('j') | no next file with comments »