Issue 24267023: Update implementations to use Object.identityHashCode for identity map/set

Issue 24267023: Update implementations to use Object.identityHashCode for identity map/set (Closed)

Created:
7 years, 3 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 2 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update implementations to use Object.identityHashCode for identity map/set Update map/set constructors to have an .identity() constructor as well. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=27869

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments. Add tests. Fix few bugs now that it can run. #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+295 lines, -64 lines)			Patch
M	pkg/http_server/test/http_body_test.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/lib/collection_patch.dart	View	1	15 chunks	+59 lines, -29 lines	0 comments	Download
M	sdk/lib/_internal/lib/collection_patch.dart	View	1	10 chunks	+74 lines, -18 lines	0 comments	Download
M	sdk/lib/collection/hash_map.dart	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	sdk/lib/collection/hash_set.dart	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	sdk/lib/collection/linked_hash_map.dart	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	sdk/lib/collection/linked_hash_set.dart	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
M	sdk/lib/core/map.dart	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	sdk/lib/core/set.dart	View	1	3 chunks	+13 lines, -5 lines	0 comments	Download
M	tests/corelib/corelib.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/corelib/hash_set_test.dart	View	1	3 chunks	+59 lines, -1 line	0 comments	Download
M	tests/corelib/map_test.dart	View	1	6 chunks	+45 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/24267023/diff/1/sdk/lib/_internal/lib/collection_patch.dart File sdk/lib/_internal/lib/collection_patch.dart (right): https://codereview.chromium.org/24267023/diff/1/sdk/lib/_internal/lib/collection_patch.dart#newcode466 sdk/lib/_internal/lib/collection_patch.dart:466: return nLinkedew _HashMap<K, V>(); this can't be right. ...

7 years, 3 months ago (2013-09-24 15:45:45 UTC) #2

Lasse Reichstein Nielsen

https://codereview.chromium.org/24267023/diff/1/sdk/lib/_internal/lib/collection_patch.dart File sdk/lib/_internal/lib/collection_patch.dart (right): https://codereview.chromium.org/24267023/diff/1/sdk/lib/_internal/lib/collection_patch.dart#newcode466 sdk/lib/_internal/lib/collection_patch.dart:466: return nLinkedew _HashMap<K, V>(); Fixed. https://codereview.chromium.org/24267023/diff/1/sdk/lib/collection/hash_map.dart File sdk/lib/collection/hash_map.dart (right): ...

7 years, 2 months ago (2013-09-25 09:37:05 UTC) #3

Lasse Reichstein Nielsen

7 years, 2 months ago (2013-09-25 09:44:07 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r27869 (presubmit successful).

Expand Messages | Collapse Messages