Cleanup bit casting methods between SIMD types

Cleanup bit casting methods between SIMD types

R=zra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27827

[zra, 2013-09-24 00:29:09]

lgtm with small fixes.

https://codereview.chromium.org/24240020/diff/1/runtime/lib/simd128.cc
File runtime/lib/simd128.cc (right):

https://codereview.chromium.org/24240020/diff/1/runtime/lib/simd128.cc#newcode45
runtime/lib/simd128.cc:45: DEFINE_NATIVE_ENTRY(Float32x4_fromUint32x4bits, 2) {
Float32x4_fromUint32x4Bits with a large B.

https://codereview.chromium.org/24240020/diff/1/runtime/lib/typed_data.dart
File runtime/lib/typed_data.dart (right):

https://codereview.chromium.org/24240020/diff/1/runtime/lib/typed_data.dart#n...
runtime/lib/typed_data.dart:1957: native "Float32x4_fromUint32x4bits";
Float32x4_fromUint32x4Bits with a large B

https://codereview.chromium.org/24240020/diff/1/runtime/vm/bootstrap_natives.h
File runtime/vm/bootstrap_natives.h (right):

https://codereview.chromium.org/24240020/diff/1/runtime/vm/bootstrap_natives....
runtime/vm/bootstrap_natives.h:189: V(Float32x4_fromUint32x4bits, 2)            
                                \
B

https://codereview.chromium.org/24240020/diff/1/runtime/vm/flow_graph_optimiz...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/24240020/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.cc:2186: } else if (recognized_kind ==
MethodRecognizer::kFloat32x4Uint32x4Bits) {
It's a little confusing that Float32x4 and Uint32x4 are in a different order in
this constant and in the code under the if(). Also, everywhere else, it's
AFromB, rather than AToB, I'd stick to one or the other, probably From.

https://codereview.chromium.org/24240020/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.cc:2188: new Uint32x4ToFloat32x4Instr(new
Value(call->ArgumentAt(1)),
I guess you'd have to rename this to Float32x4FromUint32x4BitsInstr.

https://codereview.chromium.org/24240020/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.cc:2212: } else if (recognized_kind ==
MethodRecognizer::kUint32x4Float32x4Bits) {
Similar here.

https://codereview.chromium.org/24240020/diff/1/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language.h (right):

https://codereview.chromium.org/24240020/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language.h:92: V(Float32x4, Float32x4.fromUint32x4Bits,
Float32x4Uint32x4Bits, 770033146)   \
Float32x4FromUint32x4Bits

https://codereview.chromium.org/24240020/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language.h:124: V(Uint32x4, Uint32x4.fromFloat32x4Bits,
Uint32x4Float32x4Bits, 1080034855)   \
Similar here.

[Cutch, 2013-09-24 16:00:05]

https://codereview.chromium.org/24240020/diff/1/runtime/lib/simd128.cc
File runtime/lib/simd128.cc (right):

https://codereview.chromium.org/24240020/diff/1/runtime/lib/simd128.cc#newcode45
runtime/lib/simd128.cc:45: DEFINE_NATIVE_ENTRY(Float32x4_fromUint32x4bits, 2) {
On 2013/09/24 00:29:09, zra wrote:
> Float32x4_fromUint32x4Bits with a large B.

Done.

https://codereview.chromium.org/24240020/diff/1/runtime/lib/typed_data.dart
File runtime/lib/typed_data.dart (right):

https://codereview.chromium.org/24240020/diff/1/runtime/lib/typed_data.dart#n...
runtime/lib/typed_data.dart:1957: native "Float32x4_fromUint32x4bits";
On 2013/09/24 00:29:09, zra wrote:
> Float32x4_fromUint32x4Bits with a large B

Done.

https://codereview.chromium.org/24240020/diff/1/runtime/vm/bootstrap_natives.h
File runtime/vm/bootstrap_natives.h (right):

https://codereview.chromium.org/24240020/diff/1/runtime/vm/bootstrap_natives....
runtime/vm/bootstrap_natives.h:189: V(Float32x4_fromUint32x4bits, 2)            
                                \
On 2013/09/24 00:29:09, zra wrote:
> B

Done.

https://codereview.chromium.org/24240020/diff/1/runtime/vm/flow_graph_optimiz...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/24240020/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.cc:2186: } else if (recognized_kind ==
MethodRecognizer::kFloat32x4Uint32x4Bits) {
On 2013/09/24 00:29:09, zra wrote:
> It's a little confusing that Float32x4 and Uint32x4 are in a different order
in
> this constant and in the code under the if(). Also, everywhere else, it's
> AFromB, rather than AToB, I'd stick to one or the other, probably From.

I have cleaned up the MethodRecognizer name to be kFloat32x4FromUint32x4Bits and
kUint32x4FromFloat32x4Bits. I will follow up with a second CL which renames the
intermediate language instructions.

https://codereview.chromium.org/24240020/diff/1/runtime/vm/intermediate_langu...
File runtime/vm/intermediate_language.h (right):

https://codereview.chromium.org/24240020/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language.h:92: V(Float32x4, Float32x4.fromUint32x4Bits,
Float32x4Uint32x4Bits, 770033146)   \
On 2013/09/24 00:29:09, zra wrote:
> Float32x4FromUint32x4Bits

Done.

https://codereview.chromium.org/24240020/diff/1/runtime/vm/intermediate_langu...
runtime/vm/intermediate_language.h:124: V(Uint32x4, Uint32x4.fromFloat32x4Bits,
Uint32x4Float32x4Bits, 1080034855)   \
On 2013/09/24 00:29:09, zra wrote:
> Similar here.

Done.

[Cutch, 2013-09-24 16:23:54]

Committed patchset #8 manually as r27827 (presubmit successful).