Cleanup bit casting methods between SIMD types

runtime/vm/flow_graph_optimizer.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph_optimizer.h"
 
 #include "vm/bit_vector.h"
 #include "vm/cha.h"
 #include "vm/dart_entry.h"
 #include "vm/flow_graph_builder.h"
@@ skipping 2165 matching lines @@
     return true;
   } else if (recognized_kind == MethodRecognizer::kFloat32x4Constructor) {
     Float32x4ConstructorInstr* con =
         new Float32x4ConstructorInstr(new Value(call->ArgumentAt(1)),
                                       new Value(call->ArgumentAt(2)),
                                       new Value(call->ArgumentAt(3)),
                                       new Value(call->ArgumentAt(4)),
                                       call->deopt_id());
     ReplaceCall(call, con);
     return true;
+  } else if (recognized_kind == MethodRecognizer::kFloat32x4Uint32x4Bits) {

[zra, 2013/09/24 00:29:09]

It's a little confusing that Float32x4 and Uint32x4 are in a different order in
this constant and in the code under the if(). Also, everywhere else, it's
AFromB, rather than AToB, I'd stick to one or the other, probably From.

[Cutch, 2013/09/24 16:00:05]

I have cleaned up the MethodRecognizer name to be kFloat32x4FromUint32x4Bits and
kUint32x4FromFloat32x4Bits. I will follow up with a second CL which renames the
intermediate language instructions.

+    Uint32x4ToFloat32x4Instr* cast =
+        new Uint32x4ToFloat32x4Instr(new Value(call->ArgumentAt(1)),

[zra, 2013/09/24 00:29:09]

I guess you'd have to rename this to Float32x4FromUint32x4BitsInstr.

+                                    call->deopt_id());
+    ReplaceCall(call, cast);
+    return true;
   }
   return false;
 }
 
 
 bool FlowGraphOptimizer::TryInlineUint32x4Constructor(
     StaticCallInstr* call,
     MethodRecognizer::Kind recognized_kind) {
   if (!ShouldInlineSimd()) {
     return false;
   }
   if (recognized_kind == MethodRecognizer::kUint32x4BoolConstructor) {
     Uint32x4BoolConstructorInstr* con = new Uint32x4BoolConstructorInstr(
         new Value(call->ArgumentAt(1)),
         new Value(call->ArgumentAt(2)),
         new Value(call->ArgumentAt(3)),
         new Value(call->ArgumentAt(4)),
         call->deopt_id());
     ReplaceCall(call, con);
     return true;
+  } else if (recognized_kind == MethodRecognizer::kUint32x4Float32x4Bits) {

[zra, 2013/09/24 00:29:09]

Similar here.

+    Float32x4ToUint32x4Instr* cast =
+        new Float32x4ToUint32x4Instr(new Value(call->ArgumentAt(1)),
+                                     call->deopt_id());
+    ReplaceCall(call, cast);
+    return true;
   }
   return false;
 }
 
 
 bool FlowGraphOptimizer::TryInlineFloat32x4Method(
     InstanceCallInstr* call,
     MethodRecognizer::Kind recognized_kind) {
   if (!ShouldInlineSimd()) {
     return false;
@@ skipping 150 matching lines @@
                     call->deopt_id(),
                     call->env(),
                     call);
       Float32x4ClampInstr* clamp = new Float32x4ClampInstr(new Value(left),
                                                            new Value(lower),
                                                            new Value(upper),
                                                            call->deopt_id());
       ReplaceCall(call, clamp);
       return true;
     }
-    case MethodRecognizer::kFloat32x4ToUint32x4: {
-      Definition* left = call->ArgumentAt(0);
-      // Type check left.
-      AddCheckClass(left,
-                    ICData::ZoneHandle(
-                        call->ic_data()->AsUnaryClassChecksForArgNr(0)),
-                    call->deopt_id(),
-                    call->env(),
-                    call);
-      Float32x4ToUint32x4Instr* cast =
-          new Float32x4ToUint32x4Instr(new Value(left), call->deopt_id());
-      ReplaceCall(call, cast);
-      return true;
-    }
     case MethodRecognizer::kFloat32x4Shuffle: {
       return InlineFloat32x4Getter(call, recognized_kind);
     }
     default:
       return false;
   }
 }
 
 
 bool FlowGraphOptimizer::TryInlineUint32x4Method(
@@ skipping 25 matching lines @@
                     call->env(),
                     call);
       Uint32x4SelectInstr* select = new Uint32x4SelectInstr(
           new Value(mask),
           new Value(trueValue),
           new Value(falseValue),
           call->deopt_id());
       ReplaceCall(call, select);
       return true;
     }
-    case MethodRecognizer::kUint32x4ToUint32x4: {
-      Definition* left = call->ArgumentAt(0);
-      // Type check left.
-      AddCheckClass(left,
-                    ICData::ZoneHandle(
-                        call->ic_data()->AsUnaryClassChecksForArgNr(0)),
-                    call->deopt_id(),
-                    call->env(),
-                    call);
-      Uint32x4ToFloat32x4Instr* cast =
-          new Uint32x4ToFloat32x4Instr(new Value(left), call->deopt_id());
-      ReplaceCall(call, cast);
-      return true;
-    }
     case MethodRecognizer::kUint32x4WithFlagX:
     case MethodRecognizer::kUint32x4WithFlagY:
     case MethodRecognizer::kUint32x4WithFlagZ:
     case MethodRecognizer::kUint32x4WithFlagW: {
       Definition* left = call->ArgumentAt(0);
       Definition* flag = call->ArgumentAt(1);
       // Type check left.
       AddCheckClass(left,
                     ICData::ZoneHandle(
                         call->ic_data()->AsUnaryClassChecksForArgNr(0)),
@@ skipping 5194 matching lines @@
   }
 
   // Insert materializations at environment uses.
   for (intptr_t i = 0; i < exits.length(); i++) {
     CreateMaterializationAt(exits[i], alloc, alloc->cls(), *fields);
   }
 }
 
 
 }  // namespace dart