Issue 2417463002: Move MockSdk into tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2417463002: Move MockSdk into tests. (Closed)

Created:
4 years, 2 months ago by scheglov

Modified:
4 years, 2 months ago

Reviewers:
pquitslund, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Move MockSdk into tests. Also make _MockSdkLibrary implement noSuchMethod() to avoid breaking because of unused methods in the future. R=pquitslund@google.com, brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/linter/commit/621865f22b841beebb10c785d04301b68bbd1dd2

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -415 lines)			Patch
M	lib/src/analysis.dart	View	3 chunks	+4 lines, -6 lines	0 comments	Download
D	lib/src/sdk.dart	View	1 chunk	+0 lines, -386 lines	0 comments	Download
M	pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	test/mock_sdk.dart	View	1 chunk	+1 line, -21 lines	0 comments	Download
M	test/rule_test.dart	View	2 chunks	+2 lines, -1 line	0 comments	Download

Total messages: 5 (1 generated)

scheglov

Committed patchset #1 (id:1) manually as 621865f22b841beebb10c785d04301b68bbd1dd2 (presubmit successful).

4 years, 2 months ago (2016-10-12 04:23:31 UTC) #4

Message was sent while issue was closed.

lgtm