Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: lib/src/analysis.dart

Issue 2417463002: Move MockSdk into tests. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/src/sdk.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/analysis.dart
diff --git a/lib/src/analysis.dart b/lib/src/analysis.dart
index f04ba60db19bda173287313bf385c944a98f46ce..255f8b77e258d80e3cb29f5d408840ff43991271 100644
--- a/lib/src/analysis.dart
+++ b/lib/src/analysis.dart
@@ -23,7 +23,6 @@ import 'package:linter/src/io.dart';
import 'package:linter/src/linter.dart';
import 'package:linter/src/project.dart';
import 'package:linter/src/rules.dart';
-import 'package:linter/src/sdk.dart';
import 'package:package_config/packages.dart' show Packages;
import 'package:package_config/packages_file.dart' as pkgfile show parse;
import 'package:package_config/src/packages_impl.dart' show MapPackages;
@@ -70,9 +69,8 @@ class AnalysisDriver {
int get numSourcesAnalyzed => _sourcesAnalyzed.length;
List<UriResolver> get resolvers {
- DartSdk sdk = options.useMockSdk
- ? new MockSdk()
- : new FolderBasedDartSdk(PhysicalResourceProvider.INSTANCE,
+ DartSdk sdk = options.mockSdk ??
+ new FolderBasedDartSdk(PhysicalResourceProvider.INSTANCE,
PhysicalResourceProvider.INSTANCE.getFolder(sdkDir));
List<UriResolver> resolvers = [new DartUriResolver(sdk)];
@@ -234,8 +232,8 @@ class DriverOptions {
/// Whether to use Dart's Strong Mode analyzer.
bool strongMode = true;
- /// Whether to use a mock SDK (to speed up testing).
- bool useMockSdk = false;
+ /// The mock SDK (to speed up testing) or `null` to use the actual SDK.
+ DartSdk mockSdk;
/// Whether to show lints for the transitive closure of imported and exported
/// libraries.
« no previous file with comments | « no previous file | lib/src/sdk.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698