Issue 24125002: Fixing Element.shadowRoot JS type annotation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24125002: Fixing Element.shadowRoot JS type annotation (Closed)

Created:
7 years, 3 months ago by blois

Modified:
7 years, 3 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fixing Element.shadowRoot JS type annotation Getter was annotated as never returning null, but in fact can return null. BUG= R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=27455

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	sdk/lib/html/dart2js/html_dart2js.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tools/dom/templates/html/impl/impl_Element.darttemplate	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

blois

7 years, 3 months ago (2013-09-12 22:20:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r27455 (presubmit successful).