sdk/lib/html/dart2js/html_dart2js.dart - Issue 24125002: Fixing Element.shadowRoot JS type annotation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Side-by-side diff isn't available for this file because of its large size.

Issue 24125002: Fixing Element.shadowRoot JS type annotation (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/html/dart2js/html_dart2js.dart

diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart

index d1c969d3da01e4d6c23aea16f69746b645c45948..40e5634ad3812b6ed99b5b32d8ac3c04b3ec01d4 100644

--- a/sdk/lib/html/dart2js/html_dart2js.dart

+++ b/sdk/lib/html/dart2js/html_dart2js.dart

@@ -9398,7 +9398,7 @@ abstract class Element extends Node implements ParentNode, ChildNode native "Ele

@SupportedBrowser(SupportedBrowser.CHROME, '25')

@Experimental()

ShadowRoot get shadowRoot =>

- JS('ShadowRoot', '#.shadowRoot || #.webkitShadowRoot', this, this);

+ JS('ShadowRoot|Null', '#.shadowRoot || #.webkitShadowRoot', this, this);

/**

« no previous file with comments | « no previous file | tools/dom/templates/html/impl/impl_Element.darttemplate » ('j') | no next file with comments »