Silently handle handle eval exceptions in PolymerExpressions

Silently handle handle eval exceptions in PolymerExpressions

BUG=
R=jmesserly@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27672

[justinfagnani, 2013-09-18 18:19:17]

Fixes https://code.google.com/p/dart/issues/detail?id=12659

[Jennifer Messerly, 2013-09-18 18:52:27]

Code changes look great. Some test comments :)

https://codereview.chromium.org/24031006/diff/3001/pkg/polymer_expressions/ex...
File pkg/polymer_expressions/example/example.dart (right):

https://codereview.chromium.org/24031006/diff/3001/pkg/polymer_expressions/ex...
pkg/polymer_expressions/example/example.dart:15:
Logger.root.onRecord.listen((LogRecord r) {
listen specifically for polymer_expressions in the example?

https://codereview.chromium.org/24031006/diff/3001/pkg/polymer_expressions/te...
File pkg/polymer_expressions/test/syntax_test.dart (right):

https://codereview.chromium.org/24031006/diff/3001/pkg/polymer_expressions/te...
pkg/polymer_expressions/test/syntax_test.dart:68: var logFuture =
Logger.root.onRecord.toList();
hmmm, I think this should be scoped to polymer_expressions logger. Otherwise if
someone else (probably me :) ) adds logging to another level of the system, it
can break this test.

https://codereview.chromium.org/24031006/diff/3001/pkg/polymer_expressions/te...
pkg/polymer_expressions/test/syntax_test.dart:73: ..model = null;
fyi -- I don't think setting model to null is required. setting the binding
delegate should be enough. See:

https://github.com/dart-lang/bleeding_edge/blob/bed46364329287aa4fc5da95f8593...

maybe fix the other tests too?

https://codereview.chromium.org/24031006/diff/3001/pkg/polymer_expressions/te...
pkg/polymer_expressions/test/syntax_test.dart:74: return new Future(() =>
null).then((_) {
confused by `new Future(() => null).then((_) {` ... did you mean `new Future(()
{`

https://codereview.chromium.org/24031006/diff/3001/pkg/polymer_expressions/te...
pkg/polymer_expressions/test/syntax_test.dart:78: expect(records.first.message,
contains('Error evaluating expression'));
long line. records[0].message? :)

[justinfagnani, 2013-09-18 21:56:29]

PTAL

https://codereview.chromium.org/24031006/diff/3001/pkg/polymer_expressions/ex...
File pkg/polymer_expressions/example/example.dart (right):

https://codereview.chromium.org/24031006/diff/3001/pkg/polymer_expressions/ex...
pkg/polymer_expressions/example/example.dart:15:
Logger.root.onRecord.listen((LogRecord r) {
On 2013/09/18 18:52:27, John Messerly wrote:
> listen specifically for polymer_expressions in the example?

Done.

https://codereview.chromium.org/24031006/diff/3001/pkg/polymer_expressions/te...
File pkg/polymer_expressions/test/syntax_test.dart (right):

https://codereview.chromium.org/24031006/diff/3001/pkg/polymer_expressions/te...
pkg/polymer_expressions/test/syntax_test.dart:73: ..model = null;
On 2013/09/18 18:52:27, John Messerly wrote:
> fyi -- I don't think setting model to null is required. setting the binding
> delegate should be enough. See:
> 
>
https://github.com/dart-lang/bleeding_edge/blob/bed46364329287aa4fc5da95f8593...
> 
> maybe fix the other tests too?

Done.

https://codereview.chromium.org/24031006/diff/3001/pkg/polymer_expressions/te...
pkg/polymer_expressions/test/syntax_test.dart:74: return new Future(() =>
null).then((_) {
On 2013/09/18 18:52:27, John Messerly wrote:
> confused by `new Future(() => null).then((_) {` ... did you mean `new
Future(()
> {`

Done.

https://codereview.chromium.org/24031006/diff/3001/pkg/polymer_expressions/te...
pkg/polymer_expressions/test/syntax_test.dart:78: expect(records.first.message,
contains('Error evaluating expression'));
On 2013/09/18 18:52:27, John Messerly wrote:
> long line. records[0].message? :)

Done.

[Jennifer Messerly, 2013-09-18 22:08:57]

lgtm

[justinfagnani, 2013-09-19 18:25:30]

Committed patchset #2 manually as r27672 (presubmit successful).