Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1458)

Unified Diff: pkg/polymer_expressions/test/syntax_test.dart

Issue 24031006: Silently handle handle eval exceptions in PolymerExpressions (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/polymer_expressions/test/eval_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/polymer_expressions/test/syntax_test.dart
diff --git a/pkg/polymer_expressions/test/syntax_test.dart b/pkg/polymer_expressions/test/syntax_test.dart
index 8e5b322326487c0bd2b4d1d37b27198b429e0bf6..dfc6689fc4e5a406f10f3eeffa225f05c0ace8ba 100644
--- a/pkg/polymer_expressions/test/syntax_test.dart
+++ b/pkg/polymer_expressions/test/syntax_test.dart
@@ -5,11 +5,12 @@
import 'dart:async';
import 'dart:html';
+import 'package:mdv/mdv.dart' as mdv;
+import 'package:logging/logging.dart';
+import 'package:observe/observe.dart';
import 'package:polymer_expressions/polymer_expressions.dart';
-import 'package:unittest/unittest.dart';
import 'package:unittest/html_enhanced_config.dart';
-import 'package:observe/observe.dart';
-import 'package:mdv/mdv.dart' as mdv;
+import 'package:unittest/unittest.dart';
main() {
mdv.initialize();
@@ -55,13 +56,29 @@ main() {
{{ item }}
</template>
</template>'''));
- query('#test')
- ..bindingDelegate = new PolymerExpressions(globals: {'items': null})
- ..model = null;
+ query('#test').bindingDelegate =
+ new PolymerExpressions(globals: {'items': null});
// the template should be the only node
expect(testDiv.nodes.length, 1);
expect(testDiv.nodes[0].id, 'test');
});
+
+ test('should silently handle bad variable names', () {
+ var logger = new Logger('polymer_expressions');
+ var logFuture = logger.onRecord.toList();
+ testDiv.nodes.add(new Element.html('''
+ <template id="test" bind>{{ foo }}</template>'''));
+ query('#test').bindingDelegate = new PolymerExpressions();
+ return new Future(() {
+ logger.clearListeners();
+ return logFuture.then((records) {
+ expect(records.length, 1);
+ expect(records.first.message,
+ contains('Error evaluating expression'));
+ expect(records.first.message, contains('foo'));
+ });
+ });
+ });
});
}
« no previous file with comments | « pkg/polymer_expressions/test/eval_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698