Issue 240283005: Adds simulator debugger and Stop to arm64.

Issue 240283005: Adds simulator debugger and Stop to arm64. (Closed)

Created:
6 years, 8 months ago by zra

Modified:
6 years, 8 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Adds simulator debugger and Stop to arm64. Also replaces UNIMPLEMENTED in stubs with Stop so we can enable generation. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=35127

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+413 lines, -58 lines)			Patch
M	runtime/vm/assembler_arm64.h	View	1	4 chunks	+19 lines, -2 lines	0 comments	Download
M	runtime/vm/assembler_arm64.cc	View		3 chunks	+14 lines, -6 lines	0 comments	Download
M	runtime/vm/constants_arm64.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/disassembler_arm64.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/simulator_arm64.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/simulator_arm64.cc	View	1 2	2 chunks	+335 lines, -1 line	0 comments	Download
M	runtime/vm/stub_code.cc	View		2 chunks	+0 lines, -6 lines	0 comments	Download
M	runtime/vm/stub_code_arm64.cc	View	1	3 chunks	+40 lines, -40 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zra

Simulator debugger from mips with breakpoints removed to keep things simple to start.

6 years, 8 months ago (2014-04-16 18:41:27 UTC) #1

regis

LGTM https://codereview.chromium.org/240283005/diff/20001/runtime/vm/simulator_arm64.cc File runtime/vm/simulator_arm64.cc (right): https://codereview.chromium.org/240283005/diff/20001/runtime/vm/simulator_arm64.cc#newcode39 runtime/vm/simulator_arm64.cc:39: // simulated MIPS code. MIPS -> ARM64

6 years, 8 months ago (2014-04-16 19:55:43 UTC) #2

zra

https://codereview.chromium.org/240283005/diff/20001/runtime/vm/simulator_arm64.cc File runtime/vm/simulator_arm64.cc (right): https://codereview.chromium.org/240283005/diff/20001/runtime/vm/simulator_arm64.cc#newcode39 runtime/vm/simulator_arm64.cc:39: // simulated MIPS code. On 2014/04/16 19:55:43, regis wrote: ...

6 years, 8 months ago (2014-04-16 19:57:42 UTC) #3

zra

6 years, 8 months ago (2014-04-16 19:57:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r35127 (presubmit successful).

Expand Messages | Collapse Messages