Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 23994007: Properly handle exceptions that arise when reflectively invoking a constructor/factory. (Closed)

Created:
7 years, 3 months ago by rmacnak
Modified:
7 years, 2 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Michael Lippautz (Google)
Visibility:
Public.

Description

Properly handle exceptions that arise when reflectively invoking a constructor/factory. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=27439

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -1 line) Patch
M runtime/lib/mirrors.cc View 1 chunk +2 lines, -1 line 0 comments Download
M tests/lib/lib.status View 1 chunk +1 line, -0 lines 0 comments Download
A tests/lib/mirrors/invoke_throws_test.dart View 1 chunk +70 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rmacnak
7 years, 3 months ago (2013-09-12 17:36:47 UTC) #1
siva
lgtm
7 years, 3 months ago (2013-09-12 17:40:31 UTC) #2
rmacnak
7 years, 3 months ago (2013-09-12 17:42:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r27439 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698