runtime/lib/mirrors.cc - Issue 23994007: Properly handle exceptions that arise when reflectively invoking a constructor/factory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/mirrors.cc

Issue 23994007: Properly handle exceptions that arise when reflectively invoking a constructor/factory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/lib/mirrors.cc

diff --git a/runtime/lib/mirrors.cc b/runtime/lib/mirrors.cc

index 0cbe9890be9ad9a5e7c083d45eff18e415459160..8bed35617b56c976c75d5ebec3689bcb44ea404f 100644

--- a/runtime/lib/mirrors.cc

+++ b/runtime/lib/mirrors.cc

@@ -1166,7 +1166,8 @@ DEFINE_NATIVE_ENTRY(ClassMirror_invokeConstructor, 5) {

args,

args_descriptor_array));

if (result.IsError()) {

- return result.raw();

+ ThrowInvokeError(Error::Cast(result));

+ UNREACHABLE();

}

// Factories may return null.

« no previous file with comments | « no previous file | tests/lib/lib.status » ('j') | no next file with comments »