Emit a compile-time error on members with the name of their enclosing class.

Emit a compile-time error on members with the name of their enclosing class.

R=johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27689

[Johnni Winther, 2013-09-20 06:57:35]

lgtm

https://codereview.chromium.org/23948006/diff/2001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/warnings.dart (right):

https://codereview.chromium.org/23948006/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/warnings.dart:822: "Error: Member
can't have the same name as the class it is declared in.",
Member -> Members

https://codereview.chromium.org/23948006/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/warnings.dart:823: howToFix: "Try
renaming the variable.",
Do you know it is a variable? Couldn't it be a method?

[karlklose, 2013-09-20 07:54:28]

Thanks Johnni!

https://codereview.chromium.org/23948006/diff/2001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/warnings.dart (right):

https://codereview.chromium.org/23948006/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/warnings.dart:822: "Error: Member
can't have the same name as the class it is declared in.",
It is short for 'A member', and I think that is how we use it in the other
messages. Kept for consistency, but we should perhaps have a complete review of
the style of our messages.

Changed to 'member variable'.

https://codereview.chromium.org/23948006/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/warnings.dart:823: howToFix: "Try
renaming the variable.",
On 2013/09/20 06:57:36, Johnni Winther wrote:
> Do you know it is a variable? Couldn't it be a method?

If it was a method, we would warn about the modifier/return type of the
constructor.

[karlklose, 2013-09-20 08:02:51]

Committed patchset #4 manually as r27689 (presubmit successful).