Issue 239283003: Teaches the register allocator about a second assembler temporary.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 239283003: Teaches the register allocator about a second assembler temporary. (Closed)

Created:
6 years, 8 months ago by zra

Modified:
6 years, 8 months ago

Reviewers:
regis, Florian Schneider, srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Teaches the register allocator about a second assembler temporary. ARM64 explicitly has two assembler temporaries that fall in the middle of the range of registers that Dart may otherwise use. To comply with this convention, the register allocator must recognize two TMP registers. I've called the added one TMP2, but I'm open to suggestions for other names. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=35070

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -14 lines)			Patch
M	runtime/vm/constants_arm.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/constants_arm64.h	View	5 chunks	+13 lines, -14 lines	0 comments	Download
M	runtime/vm/constants_ia32.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/constants_mips.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/constants_x64.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_allocator.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

floitsch

I'm guessing you wanted to have Florian Schneider as reviewer. Updated/Updating the CL.

6 years, 8 months ago (2014-04-15 15:56:49 UTC) #2

zra

On 2014/04/15 15:56:49, floitsch wrote: > I'm guessing you wanted to have Florian Schneider as ...

6 years, 8 months ago (2014-04-15 16:10:15 UTC) #3

zra

6 years, 8 months ago (2014-04-15 18:01:56 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 manually as r35070 (presubmit successful).

Expand Messages | Collapse Messages