Issue 23890036: Change return type of get typeVariables and typeArguments in ClassMirror.

Issue 23890036: Change return type of get typeVariables and typeArguments in ClassMirror. (Closed)

Created:
7 years, 3 months ago by zarah

Modified:
7 years, 3 months ago

Reviewers:
ahe, rmacnak, gbracha

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Change return type of get typeVariables and typeArguments in ClassMirror. R=ahe@google.com, gbracha@google.com, rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=27641

Patch Set 2 : Addressed comments. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -58 lines)			Patch
M	runtime/lib/mirrors_impl.dart	View		12 chunks	+22 lines, -23 lines	0 comments	Download
M	sdk/lib/mirrors/mirrors.dart	View	1	1 chunk	+14 lines, -16 lines	0 comments	Download
M	tests/lib/mirrors/class_mirror_type_variables_test.dart	View		2 chunks	+4 lines, -7 lines	0 comments	Download
M	tests/lib/mirrors/generics_test.dart	View		1 chunk	+2 lines, -6 lines	0 comments	Download
M	tests/lib/mirrors/mirrors_test.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/lib/mirrors/typevariable_mirror_metadata_test.dart	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM, but please wait for Ryan and Gilad as well. https://codereview.chromium.org/23890036/diff/1/sdk/lib/mirrors/mirrors.dart File sdk/lib/mirrors/mirrors.dart (right): https://codereview.chromium.org/23890036/diff/1/sdk/lib/mirrors/mirrors.dart#newcode751 ...

7 years, 3 months ago (2013-09-18 15:08:26 UTC) #2

rmacnak

LGTM https://codereview.chromium.org/23890036/diff/1/tests/lib/mirrors/typevariable_mirror_metadata_test.dart File tests/lib/mirrors/typevariable_mirror_metadata_test.dart (right): https://codereview.chromium.org/23890036/diff/1/tests/lib/mirrors/typevariable_mirror_metadata_test.dart#newcode35 tests/lib/mirrors/typevariable_mirror_metadata_test.dart:35: checkMetadata(cm.typeVariables.elementAt(0), []); cm.typeVariables[0] etc

7 years, 3 months ago (2013-09-18 17:09:57 UTC) #3

gbracha

lgtm but fix the return type of typeArguments https://codereview.chromium.org/23890036/diff/1/sdk/lib/mirrors/mirrors.dart File sdk/lib/mirrors/mirrors.dart (right): https://codereview.chromium.org/23890036/diff/1/sdk/lib/mirrors/mirrors.dart#newcode774 sdk/lib/mirrors/mirrors.dart:774: List<TypeVariableMirror> ...

7 years, 3 months ago (2013-09-18 19:54:35 UTC) #4

zarah

https://codereview.chromium.org/23890036/diff/1/sdk/lib/mirrors/mirrors.dart File sdk/lib/mirrors/mirrors.dart (right): https://codereview.chromium.org/23890036/diff/1/sdk/lib/mirrors/mirrors.dart#newcode751 sdk/lib/mirrors/mirrors.dart:751: * A list with mirrors for all type variables ...

7 years, 3 months ago (2013-09-19 07:00:24 UTC) #5

zarah

7 years, 3 months ago (2013-09-19 07:01:50 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r27641 (presubmit successful).

Expand Messages | Collapse Messages