Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: sdk/lib/mirrors/mirrors.dart

Issue 23890036: Change return type of get typeVariables and typeArguments in ClassMirror. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 // For the purposes of the mirrors library, we adopt a naming 5 // For the purposes of the mirrors library, we adopt a naming
6 // convention with respect to getters and setters. Specifically, for 6 // convention with respect to getters and setters. Specifically, for
7 // some variable or field... 7 // some variable or field...
8 // 8 //
9 // var myField; 9 // var myField;
10 // 10 //
(...skipping 730 matching lines...) Expand 10 before | Expand all | Expand 10 after
741 */ 741 */
742 Map<Symbol, VariableMirror> get variables; 742 Map<Symbol, VariableMirror> get variables;
743 743
744 /** 744 /**
745 * An immutable map from names to mirrors for all constructor 745 * An immutable map from names to mirrors for all constructor
746 * declarations for this type. 746 * declarations for this type.
747 */ 747 */
748 Map<Symbol, MethodMirror> get constructors; 748 Map<Symbol, MethodMirror> get constructors;
749 749
750 /** 750 /**
751 * An immutable map from names to mirrors for all type variables for 751 * A list with mirrors for all type variables for this type.
ahe 2013/09/18 15:08:27 an immutable list
zarah 2013/09/19 07:00:24 Done.
752 * this type.
753 * If this type is a generic declaration or an invocation of
754 * a generic declaration, the returned map has the names of the formal
755 * type parameters of the original declaration as its keys, and
756 * each such key maps to a TypeVariableMirror on the corresponding
757 * type variable. Otherwise, the returned map is empty.
758 * 752 *
759 * This map preserves the order of declaration of the type variables. 753 * If this type is a generic declaration or an invocation of a generic
754 * declaration, the returned list contains mirrors on the type variables.
755 * Otherwise, the returned list is empty.
756 *
757 * This list preserves the order of declaration of the type variables.
760 */ 758 */
761 Map<Symbol, TypeVariableMirror> get typeVariables; 759 List<TypeVariableMirror> get typeVariables;
762 760
763 /** 761 /**
764 * An immutable map from names to mirrors for all type arguments for 762 * A list with mirrors for all type arguments for
ahe 2013/09/18 15:08:27 an immutable list
zarah 2013/09/19 07:00:24 Done.
765 * this type. The keys of the map are the names of the 763 * this type.
766 * corresponding type variables.
767 * 764 *
768 * If the the reflectee is an invocation of a generic class, 765 * If the the reflectee is an invocation of a generic class,
769 * the type arguments are the bindings of its type parameters. 766 * the type arguments are the bindings of its type parameters.
770 * If the reflectee is the original declaration of a generic, 767 * If the reflectee is the original declaration of a generic,
771 * it has no type arguments and this method returns an empty map. 768 * it has no type arguments and this method returns an empty list.
772 * If the reflectee is a not generic, then 769 * If the reflectee is a not generic, then
773 * it has no type arguments and this method returns an empty map. 770 * it has no type arguments and this method returns an empty list.
774 * This map preserves the order of declaration of the type variables. 771 *
772 * This list preserves the order of declaration of the type variables.
775 */ 773 */
776 Map<Symbol, TypeMirror> get typeArguments; 774 List<TypeVariableMirror> get typeArguments;
gbracha 2013/09/18 19:54:35 List<TypeMirror>
zarah 2013/09/19 07:00:24 Done.
777 775
778 /** 776 /**
779 * Is this the original declaration of this type? 777 * Is this the original declaration of this type?
780 * 778 *
781 * For most classes, they are their own original declaration. For 779 * For most classes, they are their own original declaration. For
782 * generic classes, however, there is a distinction between the 780 * generic classes, however, there is a distinction between the
783 * original class declaration, which has unbound type variables, and 781 * original class declaration, which has unbound type variables, and
784 * the instantiations of generic classes, which have bound type 782 * the instantiations of generic classes, which have bound type
785 * variables. 783 * variables.
786 */ 784 */
(...skipping 536 matching lines...) Expand 10 before | Expand all | Expand 10 after
1323 * 1321 *
1324 * When used as metadata on an import of "dart:mirrors", this metadata does 1322 * When used as metadata on an import of "dart:mirrors", this metadata does
1325 * not apply to the library in which the annotation is used, but instead 1323 * not apply to the library in which the annotation is used, but instead
1326 * applies to the other libraries (all libraries if "*" is used). 1324 * applies to the other libraries (all libraries if "*" is used).
1327 */ 1325 */
1328 final override; 1326 final override;
1329 1327
1330 const MirrorsUsed( 1328 const MirrorsUsed(
1331 {this.symbols, this.targets, this.metaTargets, this.override}); 1329 {this.symbols, this.targets, this.metaTargets, this.override});
1332 } 1330 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698