Issue 23825007: Reapply r27285: "Support dynamic as type literal."

Issue 23825007: Reapply r27285: "Support dynamic as type literal." (Closed)

Created:
7 years, 3 months ago by karlklose

Modified:
7 years, 3 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reapply r27285: "Support dynamic as type literal." Reviewed as: https://codereview.chromium.org//23978010 BUG=dartbug.com/12398 R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=27325

Patch Set 2 : Try to resolve dynamic in scope before testing for the name. #

Total comments: 2

Patch Set 3 : Address comment. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -9 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/namer.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1 2	3 chunks	+9 lines, -4 lines	0 comments	Download
M	tests/language/first_class_types_literals_test.dart	View		2 chunks	+9 lines, -0 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

karlklose

Patch set 1 is the rebased original CL and patch set 2 is the fix.

7 years, 3 months ago (2013-09-10 08:18:55 UTC) #1

ngeoffray

LGTM https://codereview.chromium.org/23825007/diff/2/sdk/lib/_internal/compiler/implementation/resolution/members.dart File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): https://codereview.chromium.org/23825007/diff/2/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode1775 sdk/lib/_internal/compiler/implementation/resolution/members.dart:1775: Element lookupAndReport(Node node, SourceString name) { Since this ...

7 years, 3 months ago (2013-09-10 08:21:18 UTC) #2

karlklose

Committed patchset #3 manually as r27325 (presubmit successful).

7 years, 3 months ago (2013-09-10 09:13:05 UTC) #3

karlklose

7 years, 3 months ago (2013-09-10 11:42:33 UTC) #4

Message was sent while issue was closed.

Thanks, Nicolas!

https://codereview.chromium.org/23825007/diff/2/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/23825007/diff/2/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:1775: Element
lookupAndReport(Node node, SourceString name) {
On 2013/09/10 08:21:18, ngeoffray wrote:
> Since this is only called once, I'd prefer inlining it in the caller.

Done.

Expand Messages | Collapse Messages