Issue 23978010: Support dynamic as type literal.

Issue 23978010: Support dynamic as type literal. (Closed)

Created:
7 years, 3 months ago by karlklose

Modified:
7 years, 3 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support dynamic as type literal. BUG=dartbug.com/12398 R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=27285

Patch Set 4 : Change dart2dart renamer. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -5 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart	View	1 2 3	1 chunk	+1 line, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/namer.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/language/first_class_types_literals_test.dart	View	1 2	2 chunks	+9 lines, -0 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://codereview.chromium.org/23978010/diff/3001/tests/language/first_class_types_literals_test.dart File tests/language/first_class_types_literals_test.dart (right): https://codereview.chromium.org/23978010/diff/3001/tests/language/first_class_types_literals_test.dart#newcode49 tests/language/first_class_types_literals_test.dart:49: Expect.throws(() => dynamic[2] = 'hest', (e) => e ...

7 years, 3 months ago (2013-09-06 12:51:08 UTC) #2

karlklose

Thanks, Nicolas. https://codereview.chromium.org/23978010/diff/3001/tests/language/first_class_types_literals_test.dart File tests/language/first_class_types_literals_test.dart (right): https://codereview.chromium.org/23978010/diff/3001/tests/language/first_class_types_literals_test.dart#newcode49 tests/language/first_class_types_literals_test.dart:49: Expect.throws(() => dynamic[2] = 'hest', (e) => ...

7 years, 3 months ago (2013-09-06 12:57:07 UTC) #3

karlklose

7 years, 3 months ago (2013-09-09 11:02:21 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r27285 (presubmit successful).

Expand Messages | Collapse Messages