Issue 23808005: Added back childNodes and getAttribute and setAttribute.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23808005: Added back childNodes and getAttribute and setAttribute. (Closed)

Created:
7 years, 3 months ago by Emily Fortuna

Modified:
7 years, 3 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Added back childNodes and getAttribute and setAttribute. This is a quick check to verify that it was this CL: https://codereview.chromium.org/23189014/ was the cause of the performance regression. If it is, I have some ideas of potential performance improvements going forward that we should investigate, and I'll also investigate why I wasn't getting this performance behavior on my machine locally. Either way, expect at least one additional change on these APIs going forward. BUG= R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=27139

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -98 lines)			Patch
M	samples/third_party/dromaeo/tests/dom-attr-html.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	samples/third_party/dromaeo/tests/dom-traverse-html.dart	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View		9 chunks	+35 lines, -56 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		7 chunks	+19 lines, -14 lines	0 comments	Download
M	sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart	View		1 chunk	+2 lines, -4 lines	0 comments	Download
M	tools/dom/dom.json	View	1	3 chunks	+15 lines, -5 lines	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View		2 chunks	+0 lines, -5 lines	0 comments	Download
M	tools/dom/src/AttributeMap.dart	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Node.darttemplate	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

blois

Can we mark childNodes, getAttribute and setAttribute as deprecated? lgtm otherwise.

7 years, 3 months ago (2013-09-04 18:39:31 UTC) #2

Emily Fortuna

7 years, 3 months ago (2013-09-04 19:34:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r27139 (presubmit successful).

Expand Messages | Collapse Messages