samples/third_party/dromaeo/tests/dom-attr-html.dart - Issue 23808005: Added back childNodes and getAttribute and setAttribute.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samples/third_party/dromaeo/tests/dom-attr-html.dart

Issue 23808005: Added back childNodes and getAttribute and setAttribute. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: samples/third_party/dromaeo/tests/dom-attr-html.dart

diff --git a/samples/third_party/dromaeo/tests/dom-attr-html.dart b/samples/third_party/dromaeo/tests/dom-attr-html.dart

index 3f9e9acf9c33a2585d2a263e30efbcb9c231e58f..53d8bec1639ce1d1b333ac37e727b0d861b051b0 100644

--- a/samples/third_party/dromaeo/tests/dom-attr-html.dart

+++ b/samples/third_party/dromaeo/tests/dom-attr-html.dart

@@ -18,7 +18,7 @@ void main() {

new Suite(window, 'dom-attr')

.test('getAttribute', () {

for (int i = 0; i < num; i++)

- ret = elem.attributes['id'];

+ ret = elem.getAttribute('id');

})

.test('element.property', () {

for (int i = 0; i < num * 2; i++)

@@ -26,7 +26,7 @@ void main() {

})

.test('setAttribute', () {

for (int i = 0; i < num; i++)

- a.attributes['id'] = 'foo';

+ a.setAttribute('id', 'foo');

})

.test('element.property = value', () {

for (int i = 0; i < num; i++)

« no previous file with comments | « no previous file | samples/third_party/dromaeo/tests/dom-traverse-html.dart » ('j') | no next file with comments »