Issue 23745008: Follow-up fix to my change to IsPowerOfTwo: Alignment of one means no alignment, not zero.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23745008: Follow-up fix to my change to IsPowerOfTwo: Alignment of one means no alignment, not zero. (Closed)

Created:
7 years, 3 months ago by Florian Schneider

Modified:
7 years, 3 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Follow-up fix to my change to IsPowerOfTwo: Alignment of one means no alignment, not zero. We assert that the alignment is a power of two. Therefore, platforms that do not need alignment should return alignment of one instead of zero. R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=27037

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -20 lines)			Patch
M	runtime/vm/assembler_arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/assembler_ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/assembler_ia32_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/assembler_mips.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/assembler_x64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/assembler_x64_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/native_arguments.h	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	runtime/vm/os.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/os_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/simulator_arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/simulator_mips.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

7 years, 3 months ago (2013-09-03 10:57:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r27037 (presubmit successful).

Expand Messages | Collapse Messages