runtime/vm/native_arguments.h - Issue 23745008: Follow-up fix to my change to IsPowerOfTwo: Alignment of one means no alignment, not zero.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/native_arguments.h

Issue 23745008: Follow-up fix to my change to IsPowerOfTwo: Alignment of one means no alignment, not zero. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/native_arguments.h

===================================================================

--- runtime/vm/native_arguments.h (revision 27015)

+++ runtime/vm/native_arguments.h (working copy)

@@ -29,8 +29,7 @@

#if defined(USING_SIMULATOR)

#define CHECK_STACK_ALIGNMENT { \

uword current_sp = Simulator::Current()->get_register(SPREG); \

- ASSERT((OS::ActivationFrameAlignment() == 0) || \

- (Utils::IsAligned(current_sp, OS::ActivationFrameAlignment()))); \

+ ASSERT(Utils::IsAligned(current_sp, OS::ActivationFrameAlignment())); \

}

#elif defined(TARGET_OS_WINDOWS)

// The compiler may dynamically align the stack on Windows, so do not check.

@@ -40,8 +39,7 @@

uword (*func)() = \

reinterpret_cast<uword (*)()>(StubCode::GetStackPointerEntryPoint()); \

uword current_sp = func(); \

- ASSERT((OS::ActivationFrameAlignment() == 0) || \

- (Utils::IsAligned(current_sp, OS::ActivationFrameAlignment()))); \

+ ASSERT(Utils::IsAligned(current_sp, OS::ActivationFrameAlignment())); \

}

#endif

« no previous file with comments | « runtime/vm/assembler_x64_test.cc ('k') | runtime/vm/os.h » ('j') | no next file with comments »