Fix warnings.

Fix warnings.

BUG=
R=nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27977

[nweiz, 2013-09-24 20:23:47]

https://codereview.chromium.org/23702061/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/dart.dart (right):

https://codereview.chromium.org/23702061/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/dart.dart:130: factory
CrossIsolateException.deserialize(Object error) {
It doesn't make sense to type this as Object when passing anything other than a
Map will just crash. We should either throw FormatExceptions for
incorrectly-formatted input, or just type it as Map.

https://codereview.chromium.org/23702061/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/safe_http_server.dart (right):

https://codereview.chromium.org/23702061/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/safe_http_server.dart:52: throw new
UnsupportedError("Cannot set idleTimeout.");
All of these should forward to [_inner] rather than throwing exceptions.

https://codereview.chromium.org/23702061/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/safe_http_server.dart:162: throw new
UnsupportedError("redirect() is not supported.");
Same with these.

[Bob Nystrom, 2013-09-25 17:39:12]

https://codereview.chromium.org/23702061/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/dart.dart (right):

https://codereview.chromium.org/23702061/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/dart.dart:130: factory
CrossIsolateException.deserialize(Object error) {
On 2013/09/24 20:23:48, nweiz wrote:
> It doesn't make sense to type this as Object when passing anything other than
a
> Map will just crash. We should either throw FormatExceptions for
> incorrectly-formatted input, or just type it as Map.

Changed to be Map. If this were a public API, though, I think Object is the
right answer. The fact that it's actually a map is an implementation detail we
wouldn't want to leak into the public API.

But if this was a public API, we'd actually do real validation too...

https://codereview.chromium.org/23702061/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/safe_http_server.dart (right):

https://codereview.chromium.org/23702061/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/safe_http_server.dart:52: throw new
UnsupportedError("Cannot set idleTimeout.");
On 2013/09/24 20:23:48, nweiz wrote:
> All of these should forward to [_inner] rather than throwing exceptions.

Done.

https://codereview.chromium.org/23702061/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/safe_http_server.dart:162: throw new
UnsupportedError("redirect() is not supported.");
On 2013/09/24 20:23:48, nweiz wrote:
> Same with these.

Done.

[nweiz, 2013-09-25 19:18:21]

lgtm

[Bob Nystrom, 2013-09-26 22:23:40]

Committed patchset #2 manually as r27977 (presubmit successful).