sdk/lib/_internal/pub/lib/src/version.dart - Issue 23702061: Fix warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/lib/src/version.dart

Issue 23702061: Fix warnings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Revise. Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/pub/lib/src/version.dart

diff --git a/sdk/lib/_internal/pub/lib/src/version.dart b/sdk/lib/_internal/pub/lib/src/version.dart

index 0d25c735e0767b08201397d6e867e3f03dcfa8ca..969d268039b972fece4d1b6d858d46f3203bb7ca 100644

--- a/sdk/lib/_internal/pub/lib/src/version.dart

+++ b/sdk/lib/_internal/pub/lib/src/version.dart

@@ -172,8 +172,8 @@ class Version implements Comparable<Version>, VersionConstraint {

if (aPart == null) return -1;

if (bPart == null) return 1;

- if (aPart is int) {

- if (bPart is int) {

+ if (aPart is num) {

+ if (bPart is num) {

// Compare two numbers.

return aPart.compareTo(bPart);

} else {

@@ -181,7 +181,7 @@ class Version implements Comparable<Version>, VersionConstraint {

return -1;

}

} else {

- if (bPart is int) {

+ if (bPart is num) {

// Strings come after numbers.

return 1;

} else {