Issue 23691024: If a rethrow is encountered in the catch block, then its handler must be marked that it needs stack…

Issue 23691024: If a rethrow is encountered in the catch block, then its handler must be marked that it needs stack… (Closed)

Created:
7 years, 3 months ago by srdjan

Modified:
7 years, 3 months ago

Reviewers:
siva, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Kevin Millikin (Google)

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

If a rethrow is encountered in the catch block, then its handler must be marked that it needs stacktrace. Fix issue r12584. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=26963

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -6 lines)			Patch
M	runtime/vm/code_descriptors.h	View	1 2 3 4 5	2 chunks	+12 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.h	View	1 2 3 4	2 chunks	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1 2 3 4	5 chunks	+9 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.h	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.cc	View	1 2 3 4	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2 3 4	2 chunks	+6 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/language/stack_trace_test.dart	View	1 2 3 4	1 chunk	+51 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

We might want to move this to the front end eventually. Otherwise LGTM! -Ivan https://codereview.chromium.org/23691024/diff/20001/runtime/vm/intermediate_language.h ...

7 years, 3 months ago (2013-08-31 00:06:23 UTC) #2

srdjan

https://codereview.chromium.org/23691024/diff/20001/runtime/vm/intermediate_language.h File runtime/vm/intermediate_language.h (right): https://codereview.chromium.org/23691024/diff/20001/runtime/vm/intermediate_language.h#newcode1989 runtime/vm/intermediate_language.h:1989: // 'cacth_try_index' can be CatchClauseNode::kInvalidTryIndex if the On 2013/08/31 ...

7 years, 3 months ago (2013-08-31 00:18:06 UTC) #3

srdjan

7 years, 3 months ago (2013-08-31 00:26:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #6 manually as r26963 (presubmit successful).

Expand Messages | Collapse Messages